Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-commerce): invalid descriptions in currency code dictionary #5578

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 9, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Visit the preview URL for this PR (updated for commit 8ace0a1):

https://taiga-ui--pr5578-splincode-currency-r-dms4pj04.web.app

(expires Tue, 10 Oct 2023 12:27:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Oct 9, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
335.39KB (-51B -0.01%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/runtime.(hash).js
37.73KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -54B -0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.16MB (-91B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #5578 (8ace0a1) into main (9f727c2) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5578   +/-   ##
=======================================
  Coverage   72.40%   72.40%           
=======================================
  Files        1447     1447           
  Lines       15758    15758           
  Branches     2208     2208           
=======================================
  Hits        11410    11410           
  Misses       3987     3987           
  Partials      361      361           
Flag Coverage Δ
addon-charts 71.10% <100.00%> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 78.18% <ø> (ø)
kit 70.95% <ø> (ø)
summary 72.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
projects/addon-commerce/enums/currency-code.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode force-pushed the splincode/currency/refactor branch from dbc085e to 8ace0a1 Compare October 9, 2023 12:21
@splincode splincode requested a review from waterplea October 9, 2023 12:22
@splincode splincode merged commit 9182165 into main Oct 9, 2023
40 checks passed
@splincode splincode deleted the splincode/currency/refactor branch October 9, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants