Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): add configuration with DI #5552

Merged
merged 1 commit into from
Oct 9, 2023
Merged

feat(experimental): add configuration with DI #5552

merged 1 commit into from
Oct 9, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 6, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Visit the preview URL for this PR (updated for commit 2467b87):

https://taiga-ui--pr5552-options-d91qgzpa.web.app

(expires Sat, 07 Oct 2023 14:52:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Oct 6, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
335.37KB (+178B +0.05%) +10%
demo/browser/runtime.(hash).js
37.73KB (+91B +0.24%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +269B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.16MB (+2.27KB +0.1%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #5552 (2467b87) into main (f5ec571) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main    #5552   +/-   ##
=======================================
  Coverage   72.40%   72.40%           
=======================================
  Files        1447     1447           
  Lines       15755    15758    +3     
  Branches     2208     2208           
=======================================
+ Hits        11407    11410    +3     
  Misses       3987     3987           
  Partials      361      361           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <80.00%> (+0.06%) ⬆️
addon-mobile 61.14% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 78.18% <ø> (+0.02%) ⬆️
kit 70.95% <ø> (ø)
summary 72.40% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/core/components/data-list/opt-group.directive.ts 100.00% <ø> (+33.33%) ⬆️
projects/addon-doc/addon-doc.module.ts 85.71% <80.00%> (-14.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waterplea waterplea merged commit 39ed7d7 into main Oct 9, 2023
38 of 39 checks passed
@waterplea waterplea deleted the options branch October 9, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants