Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): DropdownHover fix unexpected closing when using nested dropdown #5541

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #5395

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 5, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 5, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
37.64KB (+35B +0.09%) +10%
demo/browser/main.(hash).js
335.2KB (+22B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +57B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.15MB (+1.61KB +0.07%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Visit the preview URL for this PR (updated for commit 476d2be):

https://taiga-ui--pr5541-nested-hover-dropdow-g08x3c2j.web.app

(expires Fri, 06 Oct 2023 12:37:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@vladimirpotekhin vladimirpotekhin changed the title fix(core): tuiDropdownHover fix unexpected closing when using nested dropdown fix(core): DropdownHover fix unexpected closing when using nested dropdown Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #5541 (476d2be) into main (b2badb9) will decrease coverage by 0.02%.
Report is 5 commits behind head on main.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #5541      +/-   ##
==========================================
- Coverage   72.41%   72.40%   -0.02%     
==========================================
  Files        1447     1447              
  Lines       15753    15755       +2     
  Branches     2207     2208       +1     
==========================================
- Hits        11408    11407       -1     
- Misses       3985     3987       +2     
- Partials      360      361       +1     
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.47% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 78.16% <40.00%> (-0.08%) ⬇️
kit 70.95% <ø> (ø)
summary 72.40% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cts/core/directives/dropdown/dropdown.component.ts 43.93% <100.00%> (-0.84%) ⬇️
...re/directives/dropdown/dropdown-hover.directive.ts 31.81% <25.00%> (-5.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit 4b5d814 into main Oct 6, 2023
16 checks passed
@splincode splincode deleted the nested-hover-dropdown branch October 6, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - tuiDropdownHover: closes after canceling the selection in tui-select
3 participants