Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(demo): add an example for wrapping tooltip #5540

Merged
merged 2 commits into from
Oct 6, 2023
Merged

docs(demo): add an example for wrapping tooltip #5540

merged 2 commits into from
Oct 6, 2023

Conversation

Smedrix
Copy link
Contributor

@Smedrix Smedrix commented Oct 5, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

https://github.com/taiga-family/taiga-ui/blob/main/projects/demo/src/modules/components/tooltip/examples/1/index.html

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 5, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 5, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
335.18KB +10%
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/runtime.(hash).js
37.61KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -4B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.15MB (+343B +0.02%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #5540 (4638cef) into main (b2badb9) will not change coverage.
Report is 14 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5540   +/-   ##
=======================================
  Coverage   72.41%   72.41%           
=======================================
  Files        1447     1447           
  Lines       15753    15753           
  Branches     2207     2207           
=======================================
  Hits        11408    11408           
  Misses       3985     3985           
  Partials      360      360           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.47% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 78.23% <ø> (ø)
kit 70.95% <ø> (ø)
summary 72.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -4,3 +4,15 @@
height: 1.25rem;
min-width: 6.25rem;
}

.wrapping-tooltip {
width: fit-content;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we add:

resize: horizontal;
overflow: auto;

so we can play around with it without resizing the whole window?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I'll do it :)

@Smedrix Smedrix requested a review from waterplea October 6, 2023 13:21
@splincode splincode merged commit f5ec571 into taiga-family:main Oct 6, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants