Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-doc): example should enclose inner content #5516

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

image

What is the new behavior?

image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 2, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 2, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
333.04KB +10%
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/runtime.(hash).js
37.47KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.14MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Visit the preview URL for this PR (updated for commit 5774ee4):

https://taiga-ui--pr5516-splincode-chore-exam-ultsqtya.web.app

(expires Tue, 03 Oct 2023 11:57:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #5516 (5774ee4) into main (7f5e1e5) will increase coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #5516      +/-   ##
==========================================
+ Coverage   72.69%   72.71%   +0.01%     
==========================================
  Files        1439     1440       +1     
  Lines       15648    15658      +10     
  Branches     2191     2192       +1     
==========================================
+ Hits        11376    11385       +9     
- Misses       3916     3917       +1     
  Partials      356      356              
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.47% <100.00%> (+0.08%) ⬆️
addon-mobile 61.32% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 80.15% <85.71%> (+0.01%) ⬆️
core 78.50% <100.00%> (+<0.01%) ⬆️
kit 70.97% <ø> (ø)
summary 72.71% <92.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
projects/addon-doc/components/code/code.module.ts 100.00% <100.00%> (ø)
projects/cdk/tokens/index.ts 100.00% <100.00%> (ø)
...eld/value-decoration/value-decoration.component.ts 96.29% <100.00%> (+0.14%) ⬆️
projects/core/tokens/common-icon.ts 80.00% <100.00%> (ø)
projects/cdk/tokens/fonts-ready.ts 83.33% <83.33%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit be05e44 into main Oct 2, 2023
@splincode splincode deleted the splincode/chore/example branch October 2, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants