Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputRange should not validate quantum if textfield is focused #5401

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

nsbarsukov
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #5371

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 15, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Visit the preview URL for this PR (updated for commit b05a93c):

https://taiga-ui--pr5401-input-range-quantum-srbqqs8g.web.app

(expires Tue, 19 Sep 2023 11:46:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Sep 15, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
331.38KB (-42B -0.01%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/runtime.(hash).js
37KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -42B -0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.12MB (-42B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #5401 (b05a93c) into main (8cc1e76) will increase coverage by 0.00%.
Report is 10 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5401   +/-   ##
=======================================
  Coverage   72.67%   72.67%           
=======================================
  Files        1438     1438           
  Lines       15647    15640    -7     
  Branches     2194     2187    -7     
=======================================
- Hits        11371    11366    -5     
+ Misses       3917     3915    -2     
  Partials      359      359           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.45% <ø> (ø)
addon-mobile 61.32% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 79.95% <ø> (-0.03%) ⬇️
core 78.58% <ø> (ø)
kit 70.93% <100.00%> (+0.01%) ⬆️
summary 72.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...it/components/input-range/input-range.component.ts 83.09% <100.00%> (+3.35%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waterplea waterplea merged commit 452fc01 into main Sep 18, 2023
43 checks passed
@waterplea waterplea deleted the input-range-quantum-fix branch September 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - InputSlider & InputRange should not validate quantum if textfield is focused
4 participants