Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): incorrect InputTag table appearance and PrimitiveTextfield placeholderRaisable calculation #10052

Merged

Conversation

dequubi
Copy link
Contributor

@dequubi dequubi commented Dec 24, 2024

Fixes #10044

Also fixes incorrect placeholderRaisable calculation for PrimitiveTextfieldComponent in table context.

Before After
image image

@dequubi dequubi requested a review from a team as a code owner December 24, 2024 16:32
@dequubi dequubi requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 24, 2024 16:32
Copy link

lumberjack-bot bot commented Dec 24, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.57%. Comparing base (a1b748c) to head (1e692b6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10052   +/-   ##
=======================================
  Coverage   65.56%   65.57%           
=======================================
  Files        1222     1222           
  Lines       15907    15911    +4     
  Branches     2329     2318   -11     
=======================================
+ Hits        10429    10433    +4     
- Misses       5202     5229   +27     
+ Partials      276      249   -27     
Flag Coverage Δ
summary 65.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Dec 24, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
306.49KB (+74B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.25KB +10%
demo/browser/runtime.(hash).js
44.09KB +10%
demo/browser/styles.(hash).css
20.2KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +72B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.43MB (+218B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode
Copy link
Member

@dequubi Could you add your example to https://github.com/taiga-family/taiga-ui/blob/main/projects/demo/src/modules/components/table/examples/8/index.html

to see how it works on the e2e

@splincode splincode force-pushed the bugfix/input-tag-table-appearance branch from 50b9d75 to 0a87303 Compare December 24, 2024 18:56
@splincode splincode merged commit 416dd8b into taiga-family:main Dec 25, 2024
34 of 35 checks passed
@dequubi dequubi deleted the bugfix/input-tag-table-appearance branch December 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - TuiInputTag doesn't inherit table appearance when used in table
3 participants