Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency @taiga-ui/design-tokens to v0.158.0 #10040

Merged
merged 1 commit into from
Dec 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
"@taiga-ui/browserslist-config": "0.238.0",
"@taiga-ui/commitlint-config": "0.238.0",
"@taiga-ui/cspell-config": "0.238.0",
"@taiga-ui/design-tokens": "0.157.0",
"@taiga-ui/design-tokens": "0.158.0",
"@taiga-ui/eslint-plugin-experience": "0.238.0",
"@taiga-ui/event-plugins": "4.3.1",
"@taiga-ui/jest-config": "0.238.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,10 @@ test.describe('MultiSelect', () => {
test.describe('Examples', () => {
let documentationPage: TuiDocumentationPagePO;

test.beforeEach(async ({page, browserName}) => {
test.beforeEach(async ({page}) => {
await tuiGoto(page, DemoRoute.MultiSelect);

documentationPage = new TuiDocumentationPagePO(page);

// TODO: why does this test keep failing in safari
test.skip(
browserName !== 'chromium',
'This feature is only relevant in Chrome',
);
});

test('does not overflow arrow icon by many tags', async () => {
Expand All @@ -37,31 +31,35 @@ test.describe('MultiSelect', () => {
);
});

test('multi-select with data list with label', async () => {
test('multi-select with data list with label', async ({page}) => {
const example = documentationPage.getExample('#datalist');
const multiSelect = new TuiMultiSelectPO(
example.locator('tui-multi-select').first(),
);

await multiSelect.arrow.click();
await documentationPage.waitStableState();
await page.waitForTimeout(300);
await page.locator('tui-dropdown [tuiOption]').first().hover();

await expect(multiSelect.dropdown).toHaveScreenshot(
'02-with-data-list__with-label.png',
'02-with-data-list-with-label.png',
);
});

test('multi-select with data list without label', async () => {
test('multi-select with data list without label', async ({page}) => {
const example = documentationPage.getExample('#datalist');
const multiSelect = new TuiMultiSelectPO(
example.locator('tui-multi-select').nth(1),
);

await multiSelect.arrow.click();
await documentationPage.waitStableState();
await page.waitForTimeout(300);
await page.locator('tui-dropdown [tuiOption]').first().hover();

await expect(multiSelect.dropdown).toHaveScreenshot(
'03-with-data-list__without-label.png',
'03-with-data-list-without-label.png',
);
});

Expand Down Expand Up @@ -144,7 +142,7 @@ test.describe('MultiSelect', () => {
await documentationPage.waitStableState();

await expect(apiPageExample).toHaveScreenshot(
`06-update-on-${type}__1_initial.png`,
`06-update-on-${type}-1_initial.png`,
);

await multiSelect.arrow.click();
Expand All @@ -153,35 +151,35 @@ test.describe('MultiSelect', () => {
await documentationPage.waitStableState();

await expect(multiSelect.dropdown).toHaveScreenshot(
`06-update-on-${type}__2_selected-values.png`,
`06-update-on-${type}-2_selected-values.png`,
);

await multiSelect.closeDropdown();
await documentationPage.waitStableState();

await expect(apiPageExample).toHaveScreenshot(
`06-update-on-${type}__3_hide-dropdown.png`,
`06-update-on-${type}-3_hide-dropdown.png`,
);

await multiSelect.textfield.blur();
await documentationPage.waitStableState();

await expect(apiPageExample).toHaveScreenshot(
`06-update-on-${type}__4_blur-event.png`,
`06-update-on-${type}-4_blur-event.png`,
);

await documentationPage.submitFormControlButton.click();
await documentationPage.waitStableState();

await expect(apiPageExample).toHaveScreenshot(
`06-update-on-${type}__5_submit-event.png`,
`06-update-on-${type}-5_submit-event.png`,
);

await documentationPage.resetFormControlButton.click();
await documentationPage.waitStableState();

await expect(apiPageExample).toHaveScreenshot(
`06-update-on-${type}__6_reset.png`,
`06-update-on-${type}-6_reset.png`,
);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ test.describe('Select', () => {

test('checkmark size', async ({page}) => {
const example = documentationPage.getExample('#template');
const select = new TuiSelectPO(example.locator('tui-select').first());
const selectLocator = example.locator('tui-select').first();
const select = new TuiSelectPO(selectLocator);

await selectLocator.scrollIntoViewIfNeeded();
await select.textfield.click();

await expect(select.dropdown).toBeVisible();
Expand All @@ -32,8 +34,10 @@ test.describe('Select', () => {

test('opens dropdown by click on icon', async ({page}) => {
const example = documentationPage.getExample('#base');
const select = new TuiSelectPO(example.locator('tui-select').last());
const selectLocator = example.locator('tui-select').first();
const select = new TuiSelectPO(selectLocator);

await selectLocator.scrollIntoViewIfNeeded();
await select.textfield.click({position: {x: 200, y: 30}});

await expect(select.dropdown).toBeVisible();
Expand Down
Loading