#9721 - Remove tui-table classes from demo
#10029
Conversation
…feature/9721-migrate-tui-table-classes
shiv9604
requested review from
MarsiBarsi,
waterplea,
nsbarsukov,
vladimirpotekhin and
mdlufy
and removed request for
a team
Failed tests ❌Before (main) ← Diff → After (local)tests-kit-dropdown-context-624d8-ens-dropdown-on-right-click-chromium-retry2/01-dropdown-context.diff.png
tests-kit-dropdown-context-45008--nested-dropdown-is-clicked-chromium-retry2/04-dropdown-context.diff.png
tests-kit-dropdown-context-d7fb4-own-after-new-one-is-opened-chromium-retry2/02-dropdown-context.diff.png
tests-kit-dropdown-context-624d8-ens-dropdown-on-right-click-webkit-retry2/01-dropdown-context.diff.png
tests-kit-dropdown-context-45008--nested-dropdown-is-clicked-webkit-retry2/04-dropdown-context.diff.png
tests-kit-dropdown-context-d7fb4-own-after-new-one-is-opened-webkit-retry2/02-dropdown-context.diff.png
(updated for commit 72e9f45) |
shiv9604
changed the title
tui-table classes from demo
BundleMonUnchanged files (5)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
shiv9604
changed the title
tui-table classes from demotui-table classes from demo
|
Visit the preview URL for this PR (updated for commit 72e9f45): https://taiga-previews-demo--pr10029-feature-9721-migrate-tui-inha1i6i.web.app (expires Fri, 20 Dec 2024 07:17:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
shiv9604
changed the title
tui-table classes from demotui-table classes from demo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10029 +/- ##
=======================================
Coverage 66.13% 66.13%
=======================================
Files 1215 1215
Lines 15720 15720
Branches 2310 2272 -38
=======================================
Hits 10397 10397
- Misses 5085 5116 +31
+ Partials 238 207 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Failed testschromium › tests/kit/dropdown-context/dropdown-context.pw.spec.ts › DropdownContext › opens dropdown on right click Flaky testswebkit › tests/core/hint/hint.pw.spec.ts › TuiHint › false mode hint with delay Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
| @@ -2,12 +2,34 @@ import {NgForOf} from '@angular/common'; | |||
| import {Component, inject} from '@angular/core'; | |||
| import {changeDetection} from '@demo/emulate/change-detection'; | |||
| import {encapsulation} from '@demo/emulate/encapsulation'; | |||
| import { | |||
| TuiTable, | |||
There was a problem hiding this comment.
TuiTable is enough, it's already a constant with all other standalone directives:
https://github.com/taiga-family/taiga-ui/blob/main/projects/addon-table/components/table/table.ts
There was a problem hiding this comment.
Ahh, I see! Thanks for informing me.
| border-inline-end: none; | ||
| } | ||
|
|
||
| [tuiTd] { |
There was a problem hiding this comment.
Let's also remove border-block-start form [tuiTh] so it looks more like it used to.
There was a problem hiding this comment.
Yeah, header border is appearing
| } | ||
|
|
||
| td { | ||
| inline-size: 18.75rem; |
There was a problem hiding this comment.
Why is it not under [tuiTd] above?
There was a problem hiding this comment.
It was existing code so I didn't touch that, Let me transform to attribute selector under [tuiTd].
| imports: [TuiDemo], | ||
| imports: [ | ||
| TuiDemo, | ||
| TuiTable, |
| @@ -2,6 +2,14 @@ import {NgForOf} from '@angular/common'; | |||
| import {Component} from '@angular/core'; | |||
| import {changeDetection} from '@demo/emulate/change-detection'; | |||
| import {encapsulation} from '@demo/emulate/encapsulation'; | |||
| import { | |||
| TuiTable, | |||
shiv9604
force-pushed
the
feature/9721-migrate-tui-table-classes
branch
from
165a82c to
72e9f45
Compare
Fixes #9721
Changes Description:-
Migrated tui-form classes from the below pages.