Skip to content

feat(core): refactor dialogs to no longer require module import #8965

feat(core): refactor dialogs to no longer require module import

feat(core): refactor dialogs to no longer require module import #8965

Triggered via pull request February 1, 2024 16:53
@splincodesplincode
synchronize #6646
popover
Status Failure
Total duration 24m 5s
Artifacts 1

e2e.yml

on: pull_request
Matrix: playwright
E2E result
7s
E2E result
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 9 warnings, and 16 notices
[chromium] › tests/core/dialogs/dialog-browser-back.spec.ts:7:9 › Dialogs + browser back navigation › closes dialog on browser back navigation: projects/demo-playwright/tests/core/dialogs/dialog-browser-back.spec.ts#L23
1) [chromium] › tests/core/dialogs/dialog-browser-back.spec.ts:7:9 › Dialogs + browser back navigation › closes dialog on browser back navigation Error: Screenshot comparison failed: 721368 pixels (ratio 0.36 of all image pixels) are different. Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/core/dialogs/dialog-browser-back.spec.ts-snapshots/02-dialog-browser-back-chromium-linux.png Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-core-dialogs-dialog-browser-back-Dialogs-f9c09-gation-closes-dialog-on-browser-back-navigation-chromium/02-dialog-browser-back-actual.png Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-core-dialogs-dialog-browser-back-Dialogs-f9c09-gation-closes-dialog-on-browser-back-navigation-chromium/02-dialog-browser-back-diff.png Call log: - page._expectScreenshot with timeout 5000ms - verifying given screenshot expectation - taking page screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - 721368 pixels (ratio 0.36 of all image pixels) are different. - waiting 100ms before taking screenshot - taking page screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - captured a stable screenshot - 721368 pixels (ratio 0.36 of all image pixels) are different. 21 | await page.goForward(); 22 | await api.networkidle(); > 23 | await expect(page).toHaveScreenshot('02-dialog-browser-back.png'); | ^ 24 | await expect(page).toHaveURL('components/dialog'); 25 | }); 26 | at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/core/dialogs/dialog-browser-back.spec.ts:23:28
[chromium] › tests/core/dialogs/dialog-browser-back.spec.ts:7:9 › Dialogs + browser back navigation › closes dialog on browser back navigation: projects/demo-playwright/tests/core/dialogs/dialog-browser-back.spec.ts#L18
1) [chromium] › tests/core/dialogs/dialog-browser-back.spec.ts:7:9 › Dialogs + browser back navigation › closes dialog on browser back navigation Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 109 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/core/dialogs/dialog-browser-back.spec.ts-snapshots/01-dialog-browser-back-chromium-linux.png Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-core-dialogs-dialog-browser-back-Dialogs-f9c09-gation-closes-dialog-on-browser-back-navigation-chromium-retry1/01-dialog-browser-back-actual.png Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-core-dialogs-dialog-browser-back-Dialogs-f9c09-gation-closes-dialog-on-browser-back-navigation-chromium-retry1/01-dialog-browser-back-diff.png Call log: - page._expectScreenshot with timeout 5000ms - verifying given screenshot expectation - taking page screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - 109 pixels (ratio 0.01 of all image pixels) are different. - waiting 100ms before taking screenshot - taking page screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - captured a stable screenshot - 109 pixels (ratio 0.01 of all image pixels) are different. 16 | await api.networkidle(); 17 | await api.prepareBeforeScreenshot(); > 18 | await expect(page).toHaveScreenshot('01-dialog-browser-back.png'); | ^ 19 | await page.goBack(); 20 | await api.networkidle(); 21 | await page.goForward(); at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/core/dialogs/dialog-browser-back.spec.ts:18:28
[chromium] › tests/core/dialogs/dialog-browser-back.spec.ts:7:9 › Dialogs + browser back navigation › closes dialog on browser back navigation: projects/demo-playwright/tests/core/dialogs/dialog-browser-back.spec.ts#L23
1) [chromium] › tests/core/dialogs/dialog-browser-back.spec.ts:7:9 › Dialogs + browser back navigation › closes dialog on browser back navigation Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 721368 pixels (ratio 0.36 of all image pixels) are different. Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/core/dialogs/dialog-browser-back.spec.ts-snapshots/02-dialog-browser-back-chromium-linux.png Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-core-dialogs-dialog-browser-back-Dialogs-f9c09-gation-closes-dialog-on-browser-back-navigation-chromium-retry2/02-dialog-browser-back-actual.png Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-core-dialogs-dialog-browser-back-Dialogs-f9c09-gation-closes-dialog-on-browser-back-navigation-chromium-retry2/02-dialog-browser-back-diff.png Call log: - page._expectScreenshot with timeout 5000ms - verifying given screenshot expectation - taking page screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - 721368 pixels (ratio 0.36 of all image pixels) are different. - waiting 100ms before taking screenshot - taking page screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - captured a stable screenshot - 721368 pixels (ratio 0.36 of all image pixels) are different. 21 | await page.goForward(); 22 | await api.networkidle(); > 23 | await expect(page).toHaveScreenshot('02-dialog-browser-back.png'); | ^ 24 | await expect(page).toHaveURL('components/dialog'); 25 | }); 26 | at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/core/dialogs/dialog-browser-back.spec.ts:23:28
playwright / (1 of 8)
Process completed with exit code 1.
[chromium] › tests/kit/dropdown-context/dropdown-context.spec.ts:19:9 › DropdownContext › closes previous dropdown after new one is opened: projects/demo-playwright/tests/kit/dropdown-context/dropdown-context.spec.ts#L29
1) [chromium] › tests/kit/dropdown-context/dropdown-context.spec.ts:19:9 › DropdownContext › closes previous dropdown after new one is opened Error: Screenshot comparison failed: 5643 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/dropdown-context/dropdown-context.spec.ts-snapshots/03-dropdown-context-chromium-linux.png Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium/03-dropdown-context-actual.png Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium/03-dropdown-context-diff.png Call log: - page._expectScreenshot with timeout 5000ms - verifying given screenshot expectation - waiting for locator('#context-menu [automation-id="tui-doc-example"]') - locator resolved to <div _ngcontent-tui-demo-c135="" automation-id="tui-d…>…</div> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - waiting for element to be visible and stable - element is visible and stable - 5643 pixels (ratio 0.01 of all image pixels) are different. - waiting 100ms before taking screenshot - waiting for locator('#context-menu [automation-id="tui-doc-example"]') - locator resolved to <div _ngcontent-tui-demo-c135="" automation-id="tui-d…>…</div> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - waiting for element to be visible and stable - element is visible and stable - captured a stable screenshot - 5643 pixels (ratio 0.01 of all image pixels) are different. 27 | await tr.nth(2).click({button: 'right', position: {x: 0, y: 0}}); 28 | await api.networkidle(); > 29 | await expect(example).toHaveScreenshot('03-dropdown-context.png'); | ^ 30 | }); 31 | 32 | test('does not close dropdown when nested dropdown is clicked', async ({page}) => { at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/dropdown-context/dropdown-context.spec.ts:29:31
[chromium] › tests/kit/dropdown-context/dropdown-context.spec.ts:19:9 › DropdownContext › closes previous dropdown after new one is opened: projects/demo-playwright/tests/kit/dropdown-context/dropdown-context.spec.ts#L26
1) [chromium] › tests/kit/dropdown-context/dropdown-context.spec.ts:19:9 › DropdownContext › closes previous dropdown after new one is opened Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 1349 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/dropdown-context/dropdown-context.spec.ts-snapshots/02-dropdown-context-chromium-linux.png Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium-retry1/02-dropdown-context-actual.png Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium-retry1/02-dropdown-context-diff.png Call log: - page._expectScreenshot with timeout 5000ms - verifying given screenshot expectation - waiting for locator('#context-menu [automation-id="tui-doc-example"]') - locator resolved to <div _ngcontent-tui-demo-c135="" automation-id="tui-d…>…</div> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - waiting for element to be visible and stable - element is visible and stable - 1349 pixels (ratio 0.01 of all image pixels) are different. - waiting 100ms before taking screenshot - waiting for locator('#context-menu [automation-id="tui-doc-example"]') - locator resolved to <div _ngcontent-tui-demo-c135="" automation-id="tui-d…>…</div> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - waiting for element to be visible and stable - element is visible and stable - captured a stable screenshot - 1349 pixels (ratio 0.01 of all image pixels) are different. 24 | await tr.nth(1).click({button: 'right', position: {x: 0, y: 0}}); 25 | await api.networkidle(); > 26 | await expect(example).toHaveScreenshot('02-dropdown-context.png'); | ^ 27 | await tr.nth(2).click({button: 'right', position: {x: 0, y: 0}}); 28 | await api.networkidle(); 29 | await expect(example).toHaveScreenshot('03-dropdown-context.png'); at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/dropdown-context/dropdown-context.spec.ts:26:31
[chromium] › tests/kit/dropdown-context/dropdown-context.spec.ts:19:9 › DropdownContext › closes previous dropdown after new one is opened: projects/demo-playwright/tests/kit/dropdown-context/dropdown-context.spec.ts#L29
1) [chromium] › tests/kit/dropdown-context/dropdown-context.spec.ts:19:9 › DropdownContext › closes previous dropdown after new one is opened Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 5643 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/dropdown-context/dropdown-context.spec.ts-snapshots/03-dropdown-context-chromium-linux.png Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium-retry2/03-dropdown-context-actual.png Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-dropdown-context-dropdown-context-Dr-62150-loses-previous-dropdown-after-new-one-is-opened-chromium-retry2/03-dropdown-context-diff.png Call log: - page._expectScreenshot with timeout 5000ms - verifying given screenshot expectation - waiting for locator('#context-menu [automation-id="tui-doc-example"]') - locator resolved to <div _ngcontent-tui-demo-c135="" automation-id="tui-d…>…</div> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - waiting for element to be visible and stable - element is visible and stable - 5643 pixels (ratio 0.01 of all image pixels) are different. - waiting 100ms before taking screenshot - waiting for locator('#context-menu [automation-id="tui-doc-example"]') - locator resolved to <div _ngcontent-tui-demo-c135="" automation-id="tui-d…>…</div> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - waiting for element to be visible and stable - element is visible and stable - captured a stable screenshot - 5643 pixels (ratio 0.01 of all image pixels) are different. 27 | await tr.nth(2).click({button: 'right', position: {x: 0, y: 0}}); 28 | await api.networkidle(); > 29 | await expect(example).toHaveScreenshot('03-dropdown-context.png'); | ^ 30 | }); 31 | 32 | test('does not close dropdown when nested dropdown is clicked', async ({page}) => { at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/dropdown-context/dropdown-context.spec.ts:29:31
playwright / (6 of 8)
Process completed with exit code 1.
E2E result
Unable to find an artifact with the name: cypress-e2e-artifacts--5f50951a65a4f131e12ff17f6d78a5eab7d0f586-7744772969-6646
E2E result
Process completed with exit code 1.
playwright / (7 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
playwright / (4 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
playwright / (8 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
playwright / (1 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
playwright / (6 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
playwright / (5 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
playwright / (3 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
playwright / (2 of 8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
E2E result
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
🎭 Playwright Run Summary
110 passed (1.6m)
🎭 Playwright Run Summary
110 passed (1.4m)
🎭 Playwright Run Summary
110 passed (1.5m)
🎭 Playwright Run Summary
110 passed (1.7m)
🎭 Playwright Run Summary
110 passed (1.7m)
🎭 Playwright Run Summary
110 passed (1.5m)
🎭 Playwright Run Summary
1 failed [chromium] › tests/core/dialogs/dialog-browser-back.spec.ts:7:9 › Dialogs + browser back navigation › closes dialog on browser back navigation 110 passed (1.8m)
🎭 Playwright Run Summary
111 passed (1.9m)
🎭 Playwright Run Summary
110 passed (1.9m)
🎭 Playwright Run Summary
1 failed [chromium] › tests/kit/dropdown-context/dropdown-context.spec.ts:19:9 › DropdownContext › closes previous dropdown after new one is opened 109 passed (1.7m)
🎭 Playwright Run Summary
110 passed (1.7m)
🎭 Playwright Run Summary
110 passed (2.1m)
🎭 Playwright Run Summary
110 passed (2.1m)
🎭 Playwright Run Summary
110 passed (2.5m)
🎭 Playwright Run Summary
111 passed (6.6m)
🎭 Playwright Run Summary
111 passed (8.3m)

Artifacts

Produced during runtime
Name Size
playwright-e2e-artifacts--5f50951a65a4f131e12ff17f6d78a5eab7d0f586-7744772969-6646 Expired
974 KB