Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kit): Number allows to enter full width numbers #864

Merged
merged 19 commits into from
Jan 7, 2024
Merged

feat(kit): Number allows to enter full width numbers #864

merged 19 commits into from
Jan 7, 2024

Conversation

rikusen0335
Copy link
Contributor

@rikusen0335 rikusen0335 commented Jan 5, 2024 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

maskitoNumberOptionsGenerator does not accept japanese (also chinese?) full width numbers like: ０１２３４５６７８９

Close #865

What is the new behaviour?

It accepts full width numbers.

@rikusen0335
Copy link
Contributor Author

Maybe I need to make new option to accept them, due to need of transformation of full width numbers...

@rikusen0335 rikusen0335 mentioned this pull request Jan 5, 2024
Closed
9 tasks
@rikusen0335
Copy link
Contributor Author

Now this should work as I expect

@rikusen0335
Copy link
Contributor Author

OOF

@rikusen0335
Copy link
Contributor Author

Trying to run linters

@rikusen0335
Copy link
Contributor Author

Lint done

@rikusen0335
Copy link
Contributor Author

Can you run CIs again? Probably it is not code issue

@rikusen0335
Copy link
Contributor Author

cspell says "fullwidth" is not known, then what would be great to say...?

@rikusen0335
Copy link
Contributor Author

Okay, well, I added fullwidth and halfwidth to cspell configuration. Let me know if maskito team doesn't like it.

@splincode
Copy link
Member

@rikusen0335 please revert your last commit

@rikusen0335
Copy link
Contributor Author

Okay

@rikusen0335
Copy link
Contributor Author

Reverted

@rikusen0335 @splincode
fix: use full width of numbers
124f770
@rikusen0335 @splincode
Create create-fullwidth-to-halfwidth-preprocessor
2a04e00
@rikusen0335 @splincode
Rename create-fullwidth-to-halfwidth-preprocessor to create-fullwidth…
92fd94e 
…-to-halfwidth-preprocessor.ts
@rikusen0335 @splincode
Create create-fullwidth-to-halfwidth-preprocessor.ts
93c2c3e
@rikusen0335 @splincode
Delete projects/kit/src/lib/processors/create-fullwidth-to-halfwidth-…
5cd42b3 
…preprocessor.ts
@rikusen0335 @splincode
Update number-mask.ts
0fc4d9e
@rikusen0335 @splincode
Revert generate-mask-expression.ts to use default expr
97e545b
@rikusen0335 @splincode
fix: update index to export new preprocessor
02d5e94
@rikusen0335 @splincode
fix: add import of MaskitoPreprocessor
7d51307
@rikusen0335 @splincode
fix: add comment to preprocessor
91a9f22
@rikusen0335 @splincode
chore: lint
9a94269
@rikusen0335 @splincode
fix: add minus replacement, add e2e test
aa1fa93
@rikusen0335 @splincode
fix: add fullwidth and halfwidth to cspell config
89e2330
@rikusen0335 @splincode
Revert "fix: add fullwidth and halfwidth to cspell config"
0cbb6ce 
This reverts commit 3896d1e.
@rikusen0335
Copy link
Contributor Author

Fixed. Confirmed thousand separator and fullwidth replacement test works at least, and ran linter, prettier too

@rikusen0335
Copy link
Contributor Author

local cspell still saying halfwidth is unknown word. Is this okay?

@splincode
Copy link
Member

splincode commented Jan 7, 2024 •
edited
Loading

@rikusen0335 https://github.com/taiga-family/maskito/actions/runs/7437137144/job/20234500144?pr=864

passed, you forgot run npm ci before

@rikusen0335
Copy link
Contributor Author

Oh, I have to run npm ci instead of npm run lint && npm run prettier && npm run cspell xD

@splincode
Copy link
Member

@rikusen0335 after the New Year holidays (after 9 Jan), that guys will review you

@nsbarsukov @waterplea @vladimirpotekhin

@splincode splincode requested review from nsbarsukov, splincode, waterplea and vladimirpotekhin and removed request for splincode January 7, 2024 09:00
@rikusen0335
Copy link
Contributor Author

Yup, thank you

nsbarsukov
nsbarsukov reviewed Jan 7, 2024
View reviewed changes
Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know about this localization peculiarity. It is great to know it now, thanks!

Our team really appreciate your help ❤️

projects/kit/src/lib/masks/number/processors/create-fullwidth-to-halfwidth-preprocessor.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/number/processors/create-fullwidth-to-halfwidth-preprocessor.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/number/processors/index.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/constants/unicode-characters.ts Show resolved Hide resolved
@nsbarsukov nsbarsukov changed the title Use full width number to accept japanese number input feat(kit): Number allows to enter full width numbers Jan 7, 2024
@nsbarsukov nsbarsukov added the community contribution This issue was closed by a PR from the community label Jan 7, 2024
@rikusen0335
Copy link
Contributor Author

Thank you for reviewing! I really appreciate you and team created really great stuff, also it's really clean lib I've ever seen!

Requested changes done.

@rikusen0335 rikusen0335 requested a review from nsbarsukov January 7, 2024 10:53
@nsbarsukov nsbarsukov merged commit b25db10 into taiga-family:main Jan 7, 2024
32 checks passed
@nsbarsukov
Copy link
Member

nsbarsukov commented Jan 7, 2024 •
edited
Loading

This new feature will be released in Maskito 2.0.0 (the expected release date is the second half of January)

@nsbarsukov nsbarsukov mentioned this pull request Jan 10, 2024
Closed
@taiga-family-bot taiga-family-bot mentioned this pull request Jan 22, 2024
Merged
@nsbarsukov nsbarsukov mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@splincode splincode splincode approved these changes

@waterplea waterplea Awaiting requested review from waterplea

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

Assignees

@rikusen0335 rikusen0335

Labels
community contribution This issue was closed by a PR from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 - Support for full width numbers for maskitoNumberOptionsGenerator
3 participants
@rikusen0335 @splincode @nsbarsukov