fix(kit): Number has problems when prefix/postfix includes decimalSeparator symbol
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aktanoff
commented
Dec 23, 2023
projects/kit/src/lib/masks/number/processors/thousand-separator-postprocessor.ts
Outdated
Show resolved
Hide resolved
aktanoff
commented
Dec 23, 2023
projects/kit/src/lib/masks/number/processors/thousand-separator-postprocessor.ts
Show resolved
Hide resolved
splincode
force-pushed
the
fix-prefix-and-postfix-with-decimalseparator-processing
branch
from
8c54ea6 to
535c0c6
Compare
|
Thanks for your PR! I will try to explore your solution soon (tomorrow or after January 9th). Actually, I don't want to expand public API of |
This was referenced Jan 9, 2024
nsbarsukov
reviewed
Jan 9, 2024
projects/kit/src/lib/masks/number/plugins/leading-zeroes-validation.plugin.ts
Outdated
Show resolved
Hide resolved
nsbarsukov
added
the
community contribution
nsbarsukov
reviewed
Jan 9, 2024
projects/kit/src/lib/masks/number/processors/thousand-separator-postprocessor.ts
Outdated
Show resolved
Hide resolved
nsbarsukov
reviewed
Jan 9, 2024
projects/kit/src/lib/masks/number/utils/extract-prefix-and-postfix.ts
Outdated
Show resolved
Hide resolved
aktanoff
force-pushed
the
fix-prefix-and-postfix-with-decimalseparator-processing
branch
from
535c0c6 to
2b2a3b1
Compare
nsbarsukov
reviewed
Jan 15, 2024
projects/kit/src/lib/masks/number/plugins/leading-zeroes-validation.plugin.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/number/processors/decimal-zero-padding-postprocessor.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/number/processors/repeated-decimal-separator-preprocessor.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/number/processors/thousand-separator-postprocessor.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/number/processors/pseudo-character-preprocessor.ts
Outdated
Show resolved
Hide resolved
nsbarsukov
reviewed
Jan 16, 2024
...demo-integrations/src/tests/component-testing/number-postfix/number-postfix-with-point.cy.ts
Outdated
Show resolved
Hide resolved
|
@aktanoff Could you fix review comments, please ? New major release is coming. |
aktanoff
force-pushed
the
fix-prefix-and-postfix-with-decimalseparator-processing
branch
from
2b2a3b1 to
e54d368
Compare
nsbarsukov
approved these changes
Jan 18, 2024
nsbarsukov
changed the title
nsbarsukov
changed the title
Number has problems when prefix/postfix includes decimalSeparator symbol
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #703
What is the new behaviour?
Added new utility
extractPrefixAndPostfix, which extracts prefix and postfix to separate variables, and extracts cleanValue without prefix and postfix.Used it in methods, which working with decimalSeparator to avoid decimalSeparator false matching dot in prefix and postfix.
There also many things to rethink, i have 2 more ways to fix this bug:
maskitoParseNumbermaskitoParseNumberI will add tests after basic review