Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add {bubbles:true} for input events inside all built-in plugins to support ReactSyntheticEvent #806

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

aktanoff
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #804

What is the new behaviour?

Every dispatchEvent of input event now passes the bubbling stage, and it works with React

@nsbarsukov nsbarsukov changed the title feat(core): added {bubbles:true} into every dispatchEvent, to support React SyntheticEvents fix: add {bubbles:true} for input events inside all built-in plugins to support ReactSyntheticEvent Dec 20, 2023
@nsbarsukov nsbarsukov self-requested a review December 20, 2023 08:45
@nsbarsukov nsbarsukov merged commit 812c5e1 into taiga-family:main Dec 22, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Plugins, that set value into input don't call onInput in React
3 participants