Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular)!: deprecate MaskitoModule (use standalone MaskitoDirective, MaskitoCVA, MaskitoPipe) #754

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Dec 11, 2023

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behaviour?

import {Component} from '@angular/core';
import {MaskitoModule} from '@maskito/angular';
import type {MaskitoOptions} from '@maskito/core';

@Component({
  selector: 'your-component',
  template: `
    <input [maskito]="maskitoOptions" />
    Balance: ${{ value | maskito: options }}

  `,
  imports: [MaskitoModule],
})
export class YourComponent {
  readonly maskitoOptions: MaskitoOptions = {
    mask: /^\d+$/,
  };
}

What is the new behaviour?

import {Component} from '@angular/core';
import {MaskitoDirective, MaskitoPipe} from '@maskito/angular';
import type {MaskitoOptions} from '@maskito/core';

@Component({
  selector: 'your-component',
  template: `
    <input [maskito]="maskitoOptions" />
    Balance: ${{ value | maskito: options }}
  `,
  imports: [MaskitoDirective, MaskitoPipe],
})
export class YourComponent {
  readonly maskitoOptions: MaskitoOptions = {
    mask: /^\d+$/,
  };
}

+ new standalone directive MaskitoCVA

@nsbarsukov nsbarsukov self-assigned this Dec 11, 2023
Copy link
Contributor

github-actions bot commented Dec 11, 2023

Visit the preview URL for this PR (updated for commit 6bc4c88):

https://maskito--pr754-angular-standalone-rv826tvr.web.app

(expires Wed, 13 Dec 2023 09:02:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

@nsbarsukov nsbarsukov marked this pull request as ready for review December 12, 2023 08:47
@github-actions github-actions bot added the ready to merge ready label Dec 12, 2023
@nsbarsukov nsbarsukov changed the title feat(angular)!: delete MaskitoModule (use standalone Maskito, MaskitoCVA, MaskitoPipe) feat(angular)!: delete MaskitoModule (use standalone MaskitoDirective, MaskitoCVA, MaskitoPipe) Dec 12, 2023
@nsbarsukov nsbarsukov changed the title feat(angular)!: delete MaskitoModule (use standalone MaskitoDirective, MaskitoCVA, MaskitoPipe) feat(angular)!: deprecate MaskitoModule (use standalone MaskitoDirective, MaskitoCVA, MaskitoPipe) Dec 12, 2023
@nsbarsukov nsbarsukov merged commit b9e63f3 into main Dec 12, 2023
24 checks passed
@nsbarsukov nsbarsukov deleted the angular-standalone branch December 12, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants