Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Number should accept all types of spaces as interchangeable characters for thousandSeparator #505

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Sep 14, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Relates to taiga-family/taiga-ui#5388

const options = maskitoNumberOptionsGenerator({
    postfix: ' $',
    thousandSeparator: ' ', // non-breaking space!
});

const valueWithSimpleSpaces = '45 001 $';

// first one works fine
maskitoTransform(valueWithSimpleSpaces, options); // '45 001 $'

// it will return wrong value
maskitoTransform(valueWithSimpleSpaces, options); // '45 $'

Does this PR introduce a breaking change?

  • Yes
  • No

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 18788d9):

https://maskito--pr505-number-paste-bug-jstt56hb.web.app

(expires Fri, 15 Sep 2023 15:27:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

@nsbarsukov nsbarsukov marked this pull request as ready for review September 14, 2023 15:38
@github-actions github-actions bot added the ready to merge ready label Sep 15, 2023
@nsbarsukov nsbarsukov merged commit 73975bb into main Sep 15, 2023
@nsbarsukov nsbarsukov deleted the number-paste-bug branch September 15, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants