fix(angular): race condition when [maskitoOptions] are changed before long element predicate is resolved
#1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsbarsukov
requested review from
waterplea,
splincode,
vladimirpotekhin and
mdlufy
|
Visit the preview URL for this PR (updated for commit 1f56d75): https://maskito--pr1696-angular-race-conditi-6t26z51m.web.app (expires Thu, 26 Sep 2024 12:06:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 61e4dea776cbea516b68c67840913d2edd88bb90 |
splincode
approved these changes
Sep 25, 2024
…re long element predicate is resolved
splincode
force-pushed
the
angular-race-condition-fix
branch
from
23cebbf to
1f56d75
Compare
|
⛔ E2E result job has failed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates:
[maskitoOptions]are changed before long element predicate is resolved #1608