Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): incorrect behavior of overwriteMode = replace if selection contains several characters #1685

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Sep 24, 2024

Bug reproduction

  1. Open https://maskito.dev/core-concepts/overwrite-mode#replace
  2. Replace all content with 1234
  3. Select 1|23|4
  4. Press 0

Expected behavior: 104
Actual behavior: 1034

Copy link
Contributor

Visit the preview URL for this PR (updated for commit bf65383):

https://maskito--pr1685-overwrite-mode-repla-jnadzafo.web.app

(expires Wed, 25 Sep 2024 07:34:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

@nsbarsukov nsbarsukov marked this pull request as ready for review September 24, 2024 07:42
@github-actions github-actions bot added the ready to merge ready label Sep 24, 2024
@nsbarsukov nsbarsukov merged commit 67c3c10 into main Sep 24, 2024
33 checks passed
@nsbarsukov nsbarsukov deleted the overwrite-mode-replace-bug branch September 24, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants