fix(kit): Number pads integer part with zero if user selects all and then types decimal separator
#1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d then types decimal separator
|
Visit the preview URL for this PR (updated for commit 508da8d): https://maskito--pr1220-add-zero-for-single-efppwpwl.web.app (expires Sat, 04 May 2024 11:48:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 61e4dea776cbea516b68c67840913d2edd88bb90 |
nsbarsukov
requested review from
waterplea,
splincode,
vladimirpotekhin and
KrollikRoddzer
KrollikRoddzer
requested changes
May 3, 2024
projects/kit/src/lib/masks/number/processors/not-empty-integer-part-preprocessor.ts
Outdated
Show resolved
Hide resolved
KrollikRoddzer
approved these changes
May 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Open https://maskito.dev/kit/number/API?decimalSeparator=.&precision=2
Case 1
Empty textfield => Type
.=>0.✅Case 2
Textfield's value is
1.23=> select all => Type.=> empty textfield ❌New behaviour
Textfield's value is
1.23=> select all => Type.=>0.✅Closes #1219