Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): Number supports new configurable parameter minusSign #1118

Merged
merged 33 commits into from
Mar 7, 2024

Conversation

KrollikRoddzer
Copy link
Contributor

@KrollikRoddzer KrollikRoddzer commented Mar 4, 2024

Closes (#969)

Done:

  1. Added configurable parameter minusSign
  2. Added example in documentation and added this parameter to API
  3. Wrote unit and e2e tests.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Visit the preview URL for this PR (updated for commit c5cf0a0):

https://maskito--pr1118-customminussign-bmdes9q7.web.app

(expires Fri, 08 Mar 2024 08:43:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

Copy link
Contributor

github-actions bot commented Mar 4, 2024

⛔ Lint result job has failed!

@nsbarsukov nsbarsukov changed the title feat(kit): added configurable parameter minusSign to Number feat(kit): Number supports new configurable parameter minusSign Mar 5, 2024
@nsbarsukov
Copy link
Member

@KrollikRoddzer check your body description.

Wrong Closes #-statement

@nsbarsukov nsbarsukov merged commit a7bec35 into main Mar 7, 2024
31 checks passed
@nsbarsukov nsbarsukov deleted the customMinusSign branch March 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants