Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow value files and value object properties #16

Merged
merged 2 commits into from
Feb 22, 2024
Merged

feat: allow value files and value object properties #16

merged 2 commits into from
Feb 22, 2024

Conversation

leonsteinhaeuser
Copy link
Contributor

@leonsteinhaeuser leonsteinhaeuser commented Feb 22, 2024 •
edited
Loading

Description

Added support for Helm values file definitions. By default, if you configured the git generator, we will look for a values.yaml inside the values folder next to the configured argocd application configuration. The values.yaml file will be named after the Helm release name (dashes are replaced by underscores).

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@leonsteinhaeuser leonsteinhaeuser self-assigned this Feb 22, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. feature Denotes a PR to implement a new feature. labels Feb 22, 2024
@leonsteinhaeuser leonsteinhaeuser force-pushed the feat/allow-value-files-and-valueObject-properties branch from ea43e2b to 8cdc132 Compare February 22, 2024 15:43
@leonsteinhaeuser leonsteinhaeuser marked this pull request as ready for review February 22, 2024 15:45
@leonsteinhaeuser leonsteinhaeuser requested a review from a team as a code owner February 22, 2024 15:45
punknoir101
punknoir101 approved these changes Feb 22, 2024
View reviewed changes
Copy link

@punknoir101 punknoir101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leonsteinhaeuser leonsteinhaeuser merged commit 495fae4 into main Feb 22, 2024
5 checks passed
@leonsteinhaeuser leonsteinhaeuser deleted the feat/allow-value-files-and-valueObject-properties branch February 22, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punknoir101 punknoir101 punknoir101 approved these changes

Assignees

@leonsteinhaeuser leonsteinhaeuser

Labels
feature Denotes a PR to implement a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonsteinhaeuser @punknoir101