Add support to ie11 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Source | ||
|
|
||
| Forked from [url-regex](https://github.com/kevva/url-regex) so we can improve the compability with IE11 or other browsers. | ||
| Needed for consuming it from surface hubs or windows app. |
There was a problem hiding this comment.
Why we need this for the hubs and windows app ?
There was a problem hiding this comment.
url-regex was imported as a regular dependency (meaning that it would not run through Babel), and it was recently upgraded because of security reasons. The thing is that in the upgrade, some non-ie11 compliant features were introduced (like arrow functions and const declarations) and it broke our windows apps.
The other option was to change the build process to include url-regex in the babel run, but this option is safer (and the lib is simple enough)
| var ip = ipRegex.v4().source; | ||
| var host = '(?:(?:[a-z\\u00a1-\\uffff0-9][-_]*)*[a-z\\u00a1-\\uffff0-9]+)'; | ||
| var domain = '(?:\\.(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)*'; | ||
| var tld = `(?:\\.${options.strict ? '(?:[a-z\\u00a1-\\uffff]{2,})' : `(?:${tlds.sort(function (a, b) { |
There was a problem hiding this comment.
Could be useful to list in the description the two changes that you make here:
consttovar- remove arrow functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we need to fix an issue with an existent package that seems unmantained, we forked the repo.
We had an issue where the current syntax wasn't being supported in ie11 or inside a webview from WPF.
Proposed changes