Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: as coins map value serialization type now generates correct code #987

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

Gusarich
Copy link
Member

Issue

Closes #985.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.6.0 milestone Oct 25, 2024
@Gusarich Gusarich requested a review from a team as a code owner October 25, 2024 05:47
@Gusarich
Copy link
Member Author

will add tests in a moment

@anton-trunov
Copy link
Member

What about the FunC part, shouldn't it use load_coins in this case?

@Gusarich
Copy link
Member Author

What about the FunC part, shouldn't it use load_coins in this case?

at first I thought that the FunC part works fine already, but just looked through the generated code for as coins maps and turned out that it's completely wrong and just uses 257-bit long integers. I will fix that too

@Gusarich
Copy link
Member Author

but it'll be easier to fix after #941 gets merged

@Gusarich Gusarich force-pushed the fix-coins-serialization-ts branch from 87816da to a242fab Compare November 2, 2024 05:39
@Gusarich Gusarich changed the title fix: as coins map value serialization type now generates correct typescript binding fix: as coins map value serialization type now generates correct code Nov 2, 2024
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Just minor comments

CHANGELOG.md Outdated Show resolved Hide resolved
src/generator/writers/writeStdlib.ts Outdated Show resolved Hide resolved
@Gusarich Gusarich requested a review from anton-trunov November 2, 2024 07:12
@anton-trunov anton-trunov self-assigned this Nov 5, 2024
@anton-trunov anton-trunov merged commit 14b7c89 into tact-lang:main Nov 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tact serializes map<Address, Int as coins> incorrectly
2 participants