Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): destructuring statement #964

Merged
merged 8 commits into from
Nov 6, 2024
Merged

feat(docs): destructuring statement #964

merged 8 commits into from
Nov 6, 2024

Conversation

novusnota
Copy link
Member

@novusnota novusnota commented Oct 16, 2024 •
edited
Loading

Issue

A follow-up docs PR for issue #298 and PR #856.

Checklist

  • I have updated CHANGELOG.md
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota added this to the v1.6.0 milestone Oct 16, 2024
@novusnota novusnota requested a review from a team as a code owner October 16, 2024 03:26
@novusnota novusnota mentioned this pull request Oct 16, 2024
Merged
6 tasks
anton-trunov
anton-trunov requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, I especially liked the note about the unsupported nested structs. Let's fix one small inaccuracy and we are good to go

docs/src/content/docs/book/statements.mdx Outdated Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this Oct 16, 2024
@Gusarich Gusarich mentioned this pull request Oct 16, 2024
Closed
anton-trunov
anton-trunov previously approved these changes Oct 23, 2024
View reviewed changes
@novusnota novusnota mentioned this pull request Oct 24, 2024
Merged
4 tasks
Gusarich
Gusarich previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@Gusarich Gusarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jeshecdom
jeshecdom reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jeshecdom jeshecdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the explanation. It is very clear.

docs/src/content/docs/book/statements.mdx Show resolved Hide resolved
docs/src/content/docs/book/statements.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/statements.mdx Outdated Show resolved Hide resolved
jeshecdom
jeshecdom reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jeshecdom jeshecdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the associated PR #969 is approved, I will approve this PR.

@anton-trunov anton-trunov merged commit 918d51d into main Nov 6, 2024
18 checks passed
@anton-trunov anton-trunov deleted the destructuring-docs branch November 6, 2024 14:35
github-actions bot pushed a commit to TownSquareXYZ/tact that referenced this pull request Nov 7, 2024
@novusnota @github-actions
feat(docs): destructuring statement (tact-lang#964)
0c9e3d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeshecdom jeshecdom jeshecdom left review comments

@anton-trunov anton-trunov anton-trunov approved these changes

@Gusarich Gusarich Gusarich left review comments

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@novusnota @jeshecdom @anton-trunov @Gusarich