Expand font-size and font-weight scales, rename classes for clarity, fix docs #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand `font-size` type scale to ten sizes, including `4rem` as well as all the sizes from Tachyons v4. Rename `font-size` classes to use `fs` prefix: `fs1`-`fs10`, with larger numbers for larger font sizes. Largest class `fs10` has alias `fs-headline`, and next largest class `fs9` has alias `fs-subheadline`. Rename `fs-normal` class to `fstyle-normal`, so class naming is consistent: `fs` prefix for `font-size`, and `fstyle` prefix for `font-style`. New class names are all different from Tachyons v4 class names, to avoid conflicting with legacy code.
Add .fstyle-i class for font-style: italic, and use .i as an alias for fstyle-i. Update docs accordingly: specify that i, fs-headline, and fs-subheadline are aliases for other classes.
Add class fw-normal for font-weight: normal. Add class fw-b for font-weight: bold, and use class b as an alias for that class. For literal values of font-weight, rename classes fw1 through fw9 to fw-100 through fw-900, because Tachyons class names for literal values usually follow that pattern. Add class fw-1000 for font-weight: 1000. Update docs accordingly.
|
Create classes Add class for In the docstrings, the headings "Literal Values" really mean "Modifiers," so rename them as such. Update docs/class-naming.md to reflect the new class names. |
Already updated font-style and font-weight classes. Now make the corresponding updates to small, medium, and large font-style and font-weight classes.
jeremykohn
changed the title
jeremykohn
changed the title
Update docs to match the changes in CSS code for font-weight, font-size, and font-style classes.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand font-size type scale to ten sizes, including
4remas well as all the sizes from Tachyons v4. Rename font-size classes to usefsprefix:fs1-fs10, with larger numbers for larger font sizes. Largest classfs10has aliasfs-headline, and next largest classfs9has aliasfs-subheadline.Rename
fs-normalclass tofstyle-normal, so class naming is consistent:fsprefix for font-size, andfstyleprefix for font-style.New class names are all different from Tachyons v4 class names, to avoid conflicting with legacy code.