Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commit): Interactive commit message editing #8

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

tab
Copy link
Owner

@tab tab commented Oct 23, 2024

Users can now edit the commit message using their preferred text editor (env EDITOR)

tab added 5 commits October 23, 2024 21:50
…tting

Users can now edit the commit message using their preferred text editor
Revised the format guidelines for Conventional Commits to include a more comprehensive list of types and clarify the scope description.
Updated the README to include support for editing commit messages interactively before committing.
Modified the flow to allow for accepting the commit message after editing without restarting the loop.
Make Edit call without timeout context
Make Commit call with own timeout context
Use a configurable timeout value from the config package
@tab tab force-pushed the feature/interactive-edit branch from 68c7e4b to 8e8b68d Compare October 30, 2024 20:06
@tab tab merged commit a205f01 into master Oct 30, 2024
4 checks passed
@tab tab deleted the feature/interactive-edit branch October 30, 2024 20:09
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 30.64516% with 43 lines in your changes missing coverage. Please review.

Project coverage is 72.92%. Comparing base (bff5022) to head (8e8b68d).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/git/git.go 8.57% 32 Missing ⚠️
internal/commands/commit/commit.go 59.09% 9 Missing ⚠️
internal/errors/errors.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   80.73%   72.92%   -7.81%     
==========================================
  Files          11       11              
  Lines         327      458     +131     
==========================================
+ Hits          264      334      +70     
- Misses         44      105      +61     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant