Add g:choosewin_highlight_on_init to control highlighting
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorias
added a commit
to gregorias/vim-choosewin
that referenced
this pull request
Apr 7, 2023
This commit adds the ability to turn off automatic highlight group setup. This enables colorschemes to override the default settings. This change is more powerful than t9md#56, because it gives the user the control to reenable highlight groups at a later time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
g:choosewin_highlight_on_initoption that can be used to control highlightingBy default, the plugin highlights control elements on initialisation and overrides any highlighting rules from the
$VIMRCThere is a way to specify colours(e.g.
g:choosewin_color_label, etc), but it doesn't allow to link to specific highlighting rulesSo, for example, this
simply gets overridden with the built-in highlighting rules
This PR is more a proof of concept, as I haven't added tests(if any) and documentation
Maybe there is a better way that I am not aware of to achieve this without this PR, so please advise
My original idea was to make this call optional but it looks like we explicitly call
call choosewin#color#init()in thechoosewin#start