[bug] Viewhelper for getting image dimension #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs bug-64
MattiasNilsson
requested changes
Feb 15, 2017
| $dimension = $processedImage->getProperty($dimensionType); | ||
|
|
||
| } catch (ResourceDoesNotExistException $e) { | ||
| // thrown if file does not exist |
There was a problem hiding this comment.
Why are the exception not thrown? It is just suppressed.
| } catch (ResourceDoesNotExistException $e) { | ||
| // thrown if file does not exist | ||
| } catch (\UnexpectedValueException $e) { | ||
| // thrown if a file has been replaced with a folder |
There was a problem hiding this comment.
Why are the exception not thrown? It is just suppressed.
| } catch (\UnexpectedValueException $e) { | ||
| // thrown if a file has been replaced with a folder | ||
| } catch (\RuntimeException $e) { | ||
| // RuntimeException thrown if a file is outside of a storage |
There was a problem hiding this comment.
Why are the exception not thrown? It is just suppressed.
| } catch (\RuntimeException $e) { | ||
| // RuntimeException thrown if a file is outside of a storage | ||
| } catch (\InvalidArgumentException $e) { | ||
| // thrown if file storage does not exist |
There was a problem hiding this comment.
Why are the exception not thrown? It is just suppressed.
| use TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper; | ||
| use TYPO3\CMS\Fluid\Core\ViewHelper\Exception; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Add an example in the Class DOC on how to use the viewhelper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jozefspisiak
Please review the code.
And here id the link for the News list that use this viewhelper: t3kit/theme_t3kit#118
Waiting for your feedback!
Thanks