GenericGcodeDriver: Add support for grblHAL HTTP-upload. Fixes #207 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait, I didn't test well enough. Seems there must be a websocket open before the /command http call works. In my tests it worked because I had webui running in parallel. Will implement the http_command with a websocket, that should do the trick I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #207
Used apache httpclient instead of native Java 11, because it was already used by the octoprint-implementation and the native client doesn't easily support multipart/form-data.
Decided not to refactor out the net.sf.corn-client for the current use in this pull request, because if that would break things it would be better handled separately. Can provide a separate PR for that.