Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sys-form to use display: grid by default #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

btkostner
Copy link
Contributor

This makes form use display: grid by default. This removes a lot of boilerplate stuff when trying to do form inputs next to each other. Now you can just do grid things to the form and assume everything will work as intended.

@btkostner btkostner requested a review from a team as a code owner May 9, 2020 02:16
Copy link
Member

@burden burden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna have to get more familiar with grid, it seems :)

@btkostner
Copy link
Contributor Author

Holding off on this

mhmm, now that I think of it, I might want to change the grid one. Sometimes we put more than just inputs in a form and this could be a bit harder :thinking_face:

yah, I did a search in artoo for sys-form. I was going to at least make sure nothing was busted. but then again I figure that could be a project by itself when we go to update the version.

This should probably comment rewritten to be a breaking change in it's current form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants