fan: Replace heatup/cooldown logic with up/down curves #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace calculating the duty on every update with tracking the level in the fan tables to use. This allows knowing whether the system is currently heating up or cooling down. Replace the heatup and cooldown tables with an expanded fan table that defines separate up/down curves. The separate cooldown curve allows running the fans a few degrees below the initial turn-on point so that they do not constantly turn on and off at the threshold. Signed-off-by: Tim Crawford <[email protected]>
Mitigate some fan noise by using a moving average instead of instantaneous points for thermal logic. Current logic is set to update every 250ms, so use 4 points to average over 1s. Signed-off-by: Tim Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calculating the duty on every update with tracking the level in the fan tables to use. This allows knowing whether the system is currently heating up or cooling down.
Replace the heatup and cooldown tables with an expanded fan table that defines separate up/down curves. The separate cooldown curve allows running the fans a few degrees below the initial turn-on point so that they do not constantly turn on and off at the threshold.