Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgl-u: Use PECI-over-eSPI implementation #413

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/board/system76/darp7/board.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CONFIG_EC_ITE_IT5570E=y

# Enable eSPI
CONFIG_BUS_ESPI=y
CONFIG_PECI_OVER_ESPI=y

# Include keyboard
KEYBOARD=15in_102
Expand Down
5 changes: 2 additions & 3 deletions src/board/system76/darp7/gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ void gpio_init() {
GPDRD = BIT(5) | BIT(4);
// USB_PWR_EN#
GPDRE = BIT(3);
// H_PECI
GPDRF = BIT(6);
GPDRF = 0;
// H_PROCHOT_EC#
GPDRG = BIT(6);
GPDRH = 0;
Expand Down Expand Up @@ -172,7 +171,7 @@ void gpio_init() {
// TP_DATA
GPCRF5 = GPIO_ALT;
// H_PECI
GPCRF6 = GPIO_ALT;
GPCRF6 = GPIO_IN | GPIO_DOWN;
//TODO: CC_EN
GPCRF7 = GPIO_IN | GPIO_UP;
// VCCIN_AUX_PG
Expand Down
1 change: 1 addition & 0 deletions src/board/system76/galp5/board.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CONFIG_EC_ITE_IT5570E=y

# Enable eSPI
CONFIG_BUS_ESPI=y
CONFIG_PECI_OVER_ESPI=y

# Include keyboard
KEYBOARD=14in_83
Expand Down
5 changes: 2 additions & 3 deletions src/board/system76/galp5/gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ void gpio_init() {
// PWR_BTN#, SMI#
GPDRD = BIT(5) | BIT(4);
GPDRE = 0;
// H_PECI
GPDRF = BIT(6);
GPDRF = 0;
// H_PROCHOT_EC
GPDRG = BIT(6);
GPDRH = 0;
Expand Down Expand Up @@ -173,7 +172,7 @@ void gpio_init() {
// TP_DATA
GPCRF5 = GPIO_ALT | GPIO_UP;
// H_PECI
GPCRF6 = GPIO_ALT;
GPCRF6 = GPIO_IN | GPIO_DOWN;
// CC_EN: TODO!
GPCRF7 = GPIO_IN | GPIO_UP;
// dGPU_GPIO8_OVERT
Expand Down
1 change: 1 addition & 0 deletions src/board/system76/lemp10/board.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CONFIG_EC_ITE_IT5570E=y

# Enable eSPI
CONFIG_BUS_ESPI=y
CONFIG_PECI_OVER_ESPI=y

# Include keyboard
KEYBOARD=14in_83
Expand Down
5 changes: 2 additions & 3 deletions src/board/system76/lemp10/gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ void gpio_init() {
GPDRD = BIT(5) | BIT(4);
// USB_PWR_EN#
GPDRE = BIT(3);
// H_PECI
GPDRF = BIT(6);
GPDRF = 0;
GPDRG = 0;
GPDRH = 0;
GPDRI = 0;
Expand Down Expand Up @@ -170,7 +169,7 @@ void gpio_init() {
// TP_DATA
GPCRF5 = GPIO_ALT | GPIO_UP;
// H_PECI
GPCRF6 = GPIO_ALT;
GPCRF6 = GPIO_IN | GPIO_DOWN;
// CPU_C10_GATE#
GPCRF7 = GPIO_IN | GPIO_DOWN;
// VCCIN_AUX_PG
Expand Down