Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recursive binding before chroot #1204

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

PeterGrand
Copy link
Contributor

By using -R instead of -B, we ensure that the nested mount of /sys/firmware/efi/efivars/ becomes mounted in our target filesystem, which allows us to do various boot repairs with an EFI system.

@jacobgkau jacobgkau requested review from a team December 26, 2023 23:47
@jacobgkau jacobgkau self-assigned this Dec 27, 2023
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed efivars were not available in the chroot before, and are after this change. Also took a look at both flags in the mount manual page. This seems like a good change.

By using -R instead of -B, we ensure that the nested mount of /sys/firmware/efi/efivars/ becomes mounted in our target filesystem, which allows us to do various boot repairs with an EFI system.
@ahoneybun ahoneybun merged commit 11db9e3 into system76:master Jan 11, 2024
3 checks passed
@PeterGrand PeterGrand deleted the patch-1 branch January 11, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants