Bump Buildroot version and select GCC 14 with binutils 2.42 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit intends to avoid a recent glibc bug that mistakenly uses 64-bit
time on 32-bit machines.
Consider the Linux `input_event` structure:
struct input_event {
struct timeval time;
__u16 type;
__u16 code;
__s32 value;
};
On RV32 Linux, the total size of this structure should be 16 bytes (8+2+2+4).
However, due to a known glibc bug [2] that incorrectly utilizes the 64-bit time
type, the actual size of the structure becomes 24 bytes (16+2+2+4).
Without this fix, the bug would affect the usage of DirectFB2 in the semu
project. Fortunately, upgrading the toolchain version resolves the issue.
[1] https://lore.kernel.org/lkml/[email protected]/T/
[2] https://sourceware.org/pipermail/libc-help/2024-January/006563.html
jserv
requested changes
Aug 26, 2024
|
Thank @shengwen-tw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit intends to avoid a recent glibc bug that mistakenly uses 64-bit time on 32-bit machines.
Consider the Linux
input_eventstructure:On RV32 Linux, the total size of this structure should be 16 bytes (8+2+2+4). However, due to a known glibc bug [2] that incorrectly utilizes the 64-bit time type, the actual size of the structure becomes 24 bytes (16+2+2+4).
Without this fix, the bug would affect the usage of
DirectFB2in the semu project. Fortunately, upgrading the toolchain version resolves the issue.[1] https://lore.kernel.org/lkml/[email protected]/T/
[2] https://sourceware.org/pipermail/libc-help/2024-January/006563.html