scrum-1195: Set menu structure. #133
+272
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,113 @@ | ||||||
| <?xml version="1.0" encoding="utf-8"?> | ||||||
| <object xmlns:i18n="http://xml.zope.org/namespaces/i18n" | ||||||
| meta_type="Plone Actions Tool" | ||||||
| name="portal_actions" | ||||||
| > | ||||||
| <object meta_type="CMF Action Category" | ||||||
| name="portal_tabs" | ||||||
| > | ||||||
| <property name="title">Portal tabs</property> | ||||||
| <object meta_type="CMF Action" | ||||||
| name="rezensionen" | ||||||
| i18n:domain="recensio" | ||||||
| > | ||||||
| <property name="title" | ||||||
| i18n:translate="" | ||||||
| >label_nav_reviews</property> | ||||||
| <property name="description" | ||||||
| i18n:translate="" | ||||||
| /> | ||||||
| <property name="url_expr">string:${portal/rezensionen/absolute_url}/rezensionen</property> | ||||||
| <property name="link_target" /> | ||||||
| <property name="icon_expr" /> | ||||||
| <property name="available_expr" /> | ||||||
| <property name="permissions" /> | ||||||
| <property name="visible">True</property> | ||||||
| </object> | ||||||
| <object meta_type="CMF Action" | ||||||
| name="journals" | ||||||
| i18n:domain="recensio" | ||||||
| > | ||||||
| <property name="title" | ||||||
| i18n:translate="" | ||||||
| >label_nav_journals</property> | ||||||
| <property name="description" | ||||||
| i18n:translate="" | ||||||
| /> | ||||||
| <property name="url_expr">portal/rezensionen/zeitschriften/absolute_url</property> | ||||||
| <property name="link_target" /> | ||||||
| <property name="icon_expr" /> | ||||||
| <property name="available_expr" /> | ||||||
| <property name="permissions" /> | ||||||
| <property name="visible">True</property> | ||||||
| </object> | ||||||
| <object meta_type="CMF Action" | ||||||
| name="themes" | ||||||
| i18n:domain="recensio" | ||||||
| > | ||||||
| <property name="title" | ||||||
| i18n:translate="" | ||||||
| >label_nav_themes</property> | ||||||
| <property name="description" | ||||||
| i18n:translate="" | ||||||
| /> | ||||||
| <property name="url_expr">string:themen-epochen-regionen</property> | ||||||
| <property name="link_target" /> | ||||||
| <property name="icon_expr" /> | ||||||
| <property name="available_expr" /> | ||||||
| <property name="permissions" /> | ||||||
| <property name="visible">True</property> | ||||||
| </object> | ||||||
| <object meta_type="CMF Action" | ||||||
| name="authors" | ||||||
| i18n:domain="recensio" | ||||||
| > | ||||||
| <property name="title" | ||||||
| i18n:translate="" | ||||||
| >label_nav_authors</property> | ||||||
| <property name="description" | ||||||
| i18n:translate="" | ||||||
| /> | ||||||
| <property name="url_expr">string:${portal_url}/@@authorsearch</property> | ||||||
| <property name="link_target" /> | ||||||
| <property name="icon_expr" /> | ||||||
| <property name="available_expr" /> | ||||||
| <property name="permissions" /> | ||||||
| <property name="visible">True</property> | ||||||
| </object> | ||||||
| <object meta_type="CMF Action" | ||||||
| name="search" | ||||||
| i18n:domain="recensio" | ||||||
| > | ||||||
| <property name="title" | ||||||
| i18n:translate="" | ||||||
| >label_nav_search</property> | ||||||
| <property name="description" | ||||||
| i18n:translate="" | ||||||
| /> | ||||||
| <property name="url_expr">string:${portal_url}/@@search</property> | ||||||
| <property name="link_target" /> | ||||||
| <property name="icon_expr" /> | ||||||
| <property name="available_expr" /> | ||||||
| <property name="permissions" /> | ||||||
| <property name="visible">True</property> | ||||||
| </object> | ||||||
| <object meta_type="CMF Action" | ||||||
| name="aboutus" | ||||||
| i18n:domain="recensio" | ||||||
| > | ||||||
| <property name="title" | ||||||
| i18n:translate="" | ||||||
| >label_nav_about_us</property> | ||||||
| <property name="description" | ||||||
| i18n:translate="" | ||||||
| /> | ||||||
| <property name="url_expr">string:${portal_url}/ueber-uns</property> | ||||||
|
There was a problem hiding this comment. Will this work:
Suggested change
? There was a problem hiding this comment. I don't think so - we do need |
||||||
| <property name="link_target" /> | ||||||
| <property name="icon_expr" /> | ||||||
| <property name="available_expr" /> | ||||||
| <property name="permissions" /> | ||||||
| <property name="visible">True</property> | ||||||
| </object> | ||||||
| </object> | ||||||
| </object> | ||||||
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <object xmlns:i18n="http://xml.zope.org/namespaces/i18n" | ||
| meta_type="Plone Actions Tool" | ||
| name="portal_actions" | ||
| > | ||
| <object meta_type="CMF Action Category" | ||
| name="portal_tabs" | ||
| > | ||
| <property name="title">Portal tabs</property> | ||
| <object meta_type="CMF Action" | ||
| name="rezensionen" | ||
| i18n:domain="recensio" | ||
| > | ||
| <property name="title" | ||
| i18n:translate="" | ||
| >label_nav_reviews</property> | ||
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">string:${portal/rezensionen/absolute_url}/rezensionen</property> | ||
| <property name="link_target" /> | ||
| <property name="icon_expr" /> | ||
| <property name="available_expr" /> | ||
| <property name="permissions" /> | ||
| <property name="visible">True</property> | ||
| </object> | ||
| <object meta_type="CMF Action" | ||
| name="journals" | ||
| i18n:domain="recensio" | ||
| > | ||
| <property name="title" | ||
| i18n:translate="" | ||
| >label_nav_journals</property> | ||
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">portal/rezensionen/zeitschriften/absolute_url</property> | ||
| <property name="link_target" /> | ||
| <property name="icon_expr" /> | ||
| <property name="available_expr" /> | ||
| <property name="permissions" /> | ||
| <property name="visible">True</property> | ||
| </object> | ||
| <object meta_type="CMF Action" | ||
| name="themes" | ||
| i18n:domain="recensio" | ||
| > | ||
| <property name="title" | ||
| i18n:translate="" | ||
| >label_nav_themes</property> | ||
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">string:themen-epochen-regionen</property> | ||
| <property name="link_target" /> | ||
| <property name="icon_expr" /> | ||
| <property name="available_expr" /> | ||
| <property name="permissions" /> | ||
| <property name="visible">True</property> | ||
| </object> | ||
| <object meta_type="CMF Action" | ||
| name="authors" | ||
| i18n:domain="recensio" | ||
| > | ||
| <property name="title" | ||
| i18n:translate="" | ||
| >label_nav_authors</property> | ||
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">string:${portal_url}/@@authorsearch</property> | ||
| <property name="link_target" /> | ||
| <property name="icon_expr" /> | ||
| <property name="available_expr" /> | ||
| <property name="permissions" /> | ||
| <property name="visible">True</property> | ||
| </object> | ||
| <object meta_type="CMF Action" | ||
| name="search" | ||
| i18n:domain="recensio" | ||
| > | ||
| <property name="title" | ||
| i18n:translate="" | ||
| >label_nav_search</property> | ||
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">string:${portal_url}/@@search</property> | ||
| <property name="link_target" /> | ||
| <property name="icon_expr" /> | ||
| <property name="available_expr" /> | ||
| <property name="permissions" /> | ||
| <property name="visible">True</property> | ||
| </object> | ||
| <object meta_type="CMF Action" | ||
| name="aboutus" | ||
| i18n:domain="recensio" | ||
| > | ||
| <property name="title" | ||
| i18n:translate="" | ||
| >label_nav_about_us</property> | ||
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">string:${portal_url}/ueber-uns</property> | ||
| <property name="link_target" /> | ||
| <property name="icon_expr" /> | ||
| <property name="available_expr" /> | ||
| <property name="permissions" /> | ||
| <property name="visible">True</property> | ||
| </object> | ||
| </object> | ||
| </object> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| from ftw.upgrade import UpgradeStep | ||
| from plone import api | ||
|
|
||
|
|
||
| class SetMenuStructure(UpgradeStep): | ||
| """Set menu structure.""" | ||
|
|
||
| def __call__(self): | ||
| self.install_upgrade_profile() | ||
|
|
||
| # Set the "rezensionen" folder to use the "latest-review-items" layout | ||
| # for all languages | ||
| portal = api.portal.get() | ||
| reviews = portal.rezensionen | ||
|
|
||
| reviews_de = api.content.create( | ||
| container=reviews, | ||
| type="Document", | ||
| id="rezensionen", | ||
| title="Rezensionen", | ||
| language="de", | ||
| ) | ||
| reviews_de.setLayout("latest-review-items") | ||
| api.content.transition(reviews_de, "publish") | ||
|
|
||
| reviews_fr = api.content.create( | ||
| container=reviews, | ||
| type="Document", | ||
| id="recensions", | ||
| title="Recensions", | ||
| language="fr", | ||
| ) | ||
| reviews_fr.setLayout("latest-review-items") | ||
| api.content.transition(reviews_fr, "publish") | ||
|
|
||
| reviews_en = api.content.create( | ||
| container=reviews, | ||
| type="Document", | ||
| id="reviews", | ||
| title="Reviews", | ||
| language="en", | ||
| ) | ||
| reviews_en.setLayout("latest-review-items") | ||
| api.content.transition(reviews_en, "publish") | ||
|
|
||
| reviews.setDefaultPage("rezensionen") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this contains rezensionen a couple of times.
Does it make sense to change it to:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it rather be
string:${portal_url}/rezensionen/rezensionen?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was proposing that form because you had in your original PR
portal/rezensionen/absolute_url.Do whatever you like, but be consistent.
Or just don't be and ignore this nitpicky comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${portal/rezensionen/absolute_url}was from the actions.xml export I did on the testing database from https://recensio50.fe.rzob.gocept.net/But actually I didn't understand whey it was constructing the URL like that.