Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TDK image version substitution #77

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

yruchin
Copy link
Contributor

@yruchin yruchin commented Sep 25, 2024

In the attempt to appease the linter in the past, the IMAGE_VERSION env in the GHA workflow file was changed to use a block scalar. However, the used block scalar style led to the preservation of the trailing '\n', which in turn resulted in yq treating this as a multiline and using a block scalar when rendering the Docker Compose file. Docker Compose doesn't understand block scalars, at least in the image version position, so the resulting Docker Compose YAML file did not work.

This change adds the block chomping indicator to strip off the trailing newline. Also, the "folded" style was changed to "literal", as we'd still like to specify image tag on a single line, without any additional whitespace eliding by the YAML reader.

@yruchin yruchin merged commit 6841849 into main Sep 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants