Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ChiSquareContingency #179

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added ChiSquareContingency #179

wants to merge 7 commits into from

Conversation

marqueewinq
Copy link
Contributor

@marqueewinq marqueewinq commented Feb 15, 2024

Adding a KSD analog for a categoricals.

I may need help with the meaningful normalized_chi2 calculation for comparison -- let me know if you want to change the way it's done. Some idea:

        max_chi2 = dof * contingency_table.values.sum()
        normalized_chi2 = chi2 / max_chi2

@marqueewinq marqueewinq self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (88dac15) 78.8% compared to head (088a6f3) 79.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #179     +/-   ##
========================================
+ Coverage    78.8%   79.0%   +0.2%     
========================================
  Files          11      11             
  Lines         968     988     +20     
  Branches      160     163      +3     
========================================
+ Hits          763     781     +18     
- Misses        153     154      +1     
- Partials       52      53      +1     
Files Coverage Δ
src/insight/metrics/__init__.py 100.0% <ø> (ø)
src/insight/metrics/metrics.py 92.1% <90.4%> (-0.2%) ⬇️

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Major Issues (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@marqueewinq
Copy link
Contributor Author

Can ignore sonar reqs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant