Drop NaN in KolmogorovSmirnov (#175)

* Omit NaN policy in KolmogorovSmirnov * dropna instead of nan_policy
synthesized-io · Feb 7, 2024 · 34018c6 · 34018c6
1 parent 5f215f8
commit 34018c6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/insight/metrics/metrics.py b/src/insight/metrics/metrics.py
@@ -534,4 +534,5 @@ def _compute_metric(self, sr_a: pd.Series, sr_b: pd.Series) -> float:
         """
         if sr_a.empty or sr_b.empty:
             return 1.0
-        return ks_2samp(sr_a, sr_b)[0]  # The first element is the KS statistic
+
+        return ks_2samp(sr_a.dropna(), sr_b.dropna())[0]  # The first element is the KS statistic