Merge pull request #109 from synsense/hotfix/reset_mechanism

Correct test whether subtract value is None
synsense · Aug 30, 2023 · 091fb56 · 091fb56
2 parents c03ea75 + ba9a157
commit 091fb56
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/sinabs/activation/reset_mechanism.py b/sinabs/activation/reset_mechanism.py
@@ -39,7 +39,7 @@ class MembraneSubtract:
 
     def __call__(self, spikes, state, threshold):
         new_state = state.copy()
-        if self.subtract_value:
+        if self.subtract_value is not None:
             new_state["v_mem"] = new_state["v_mem"] - spikes * self.subtract_value
         else:
             new_state["v_mem"] = new_state["v_mem"] - spikes * threshold

diff --git a/tests/test_activations.py b/tests/test_activations.py
@@ -20,6 +20,12 @@
             torch.tensor([1.0, 0.0]),
             torch.tensor([1.5, 0.3]),
         ),
+        (
+            SingleSpike,
+            MembraneSubtract(subtract_value=torch.tensor([0.9, 1.1])),
+            torch.tensor([1.0, 0.0]),
+            torch.tensor([1.6, 0.3]),
+        ),
         (
             SingleSpike,
             MembraneReset(),