Verify Watch Output Index #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds @synonymdev/raw-transaction-decoder as a dependency. Creates saveAddressToFile method and implements it in getAddress method. Creates readAddressesFromFile method and implements is accordingly. Adds addresses to LightningManager class.
coreyphillips
added
bug
Jasonvdb
approved these changes
May 21, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
checkWatchOutputsto verify the output index when sweeping a force closed channel by checking the output addresses against previously generated/retrieved addresses.@synonymdev/raw-transaction-decoderas a dependency.saveAddressToFilemethod and implements it in thegetAddressmethod.readAddressesFromFilemethod and implements is accordingly.addressestoLightningManagerclass.