Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configure lib/android for android studio development #212

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Feb 20, 2024

This PR adds the necessary configuration to make it possible to open, build and edit the native android sources in lib/android directly from within Android Studio.

The reason is to streamline the DevEx on the Kotlin side, making it now possible to use code completion inside Android Studio and see git history as well.

I also added documentation on how to enable LDK JavaDocs

Android Studio 2024-02-20 001542

Validation

To validate everything is still ok I used the example app, checked all buttons still work and opened channel with a local LND node from Polar, paid invoice from LND with LDK and vice versa, then coop-closed the channel.

@ovitrif ovitrif requested a review from Jasonvdb February 20, 2024 17:37
@Jasonvdb Jasonvdb merged commit ba3d35a into master Feb 21, 2024
6 checks passed
@Jasonvdb Jasonvdb deleted the fix/lib-android-studio branch February 21, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants