Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter expired unpaid invoices and stale payment claims from storage #210

Merged
merged 10 commits into from
Feb 22, 2024

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Feb 14, 2024

Resolves #155

  1. Removes from storage expired invoices having no payment after 60min
  2. Removes from storage payment claims that are pending for over 60min

Also added small tweaks to example app:

  1. Allowing to disable couple of logs
  2. Grouping (align on same row) related buttons

coreyphillips
coreyphillips previously approved these changes Feb 15, 2024
@ovitrif
Copy link
Contributor Author

ovitrif commented Feb 20, 2024

Moved both cleanups to startup, since we don't want to increase the time it takes to sync LDK

Jasonvdb
Jasonvdb previously approved these changes Feb 21, 2024
Copy link
Collaborator

@Jasonvdb Jasonvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just some conflicts

# Conflicts:
#	backup-server/package.json
#	example/ios/Podfile.lock
#	lib/package.json
# Conflicts:
#	backup-server/package.json
#	example/ios/Podfile.lock
#	lib/package.json
@Jasonvdb Jasonvdb merged commit b5a382c into master Feb 22, 2024
6 checks passed
@Jasonvdb Jasonvdb deleted the feat/filter-expired branch February 22, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove expired invoices we never received payments for
3 participants