Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup fixes #207

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Backup fixes #207

merged 3 commits into from
Feb 2, 2024

Conversation

Jasonvdb
Copy link
Collaborator

@Jasonvdb Jasonvdb commented Feb 1, 2024

  • Sent/claimed payments files now being backed up
  • channel_opened_with_custom_keys_manager.json file now being backed up
  • Fix for android where above file was named incorrectly. It's now renamed and then backed up. (fix can be removed after a few releases)
  • iOS trigger backup of above file. (fix can be removed after a few releases)
  • Fixes a bug where misc files were not being restored with the correct extension.

ovitrif
ovitrif previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ovitrif ovitrif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

Maybe it would've made sense to rename the enum case in Swift to the same as the file name (same thing we have in Kotlin now for channelOpenedWithCustomKeysManager), though that's just aesthetics 🙈

@Jasonvdb
Copy link
Collaborator Author

Jasonvdb commented Feb 1, 2024

lgtm 👍🏻

Maybe it would've made sense to rename the enum case in Swift to the same as the file name (same thing we have in Kotlin now for channelOpenedWithCustomKeysManager), though that's just aesthetics 🙈

Cool yeah thanks I just standardized them both here

@Jasonvdb Jasonvdb merged commit 7922141 into master Feb 2, 2024
2 of 6 checks passed
@Jasonvdb Jasonvdb deleted the backup-fixes branch February 2, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovitrif ovitrif ovitrif approved these changes

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jasonvdb @limpbrains @ovitrif