Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase timeout for e2e tests #205

Merged
merged 1 commit into from
Feb 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/mocha-anrdoid.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/bash

adb reverse tcp:3003 tcp:3003
adb reverse tcp:8090 tcp:8090
adb reverse tcp:9090 tcp:9090
adb reverse tcp:9091 tcp:9091
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/mocha-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ jobs:
uses: docker-practice/[email protected]
timeout-minutes: 30

- name: Install backup-server dependencies
working-directory: backup-server
run: npm i || npm i

- name: Run regtest setup
working-directory: example/docker
run: |
Expand Down
2 changes: 1 addition & 1 deletion backup-server/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20
FROM node:20-alpine

WORKDIR /app

Expand Down
8 changes: 6 additions & 2 deletions backup-server/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions backup-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "",
"main": "index.js",
"engines": {
"npm": ">=8.0.0 <9.0.0",
"node": ">=19.0.0"
"npm": ">=8.0.0",
"node": ">=18.0.0"
},
"engineStrict" : true,
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion example/Tests.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class Tests extends Component {
// Adding an async hook before each test to allow the UI to update
beforeEach(function () {
// WFT it doesn't work ?
return new Promise((resolve) => setTimeout(resolve, 0));
return new Promise((resolve) => setTimeout(resolve, 10));
});
// global.fs = require("react-native-fs");
// global.path = require("path-browserify");
Expand Down
3 changes: 2 additions & 1 deletion example/docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ services:

ldk-backup-server:
container_name: ldk-backup-server
image: synonymsoft/ldk-backup-server:1.0.0
# image: synonymsoft/ldk-backup-server:1.0.0
build: ../../backup-server/
expose:
- '3003'
ports:
Expand Down
11 changes: 4 additions & 7 deletions example/e2e/ldk.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,19 @@ describe('LDK integration test', () => {
await element(by.id('dev')).tap();
});

it('should have heading', async () => {
it('should show "Running LDK" after starting up', async () => {
await waitFor(element(by.text('react-native-ldk')))
.toBeVisible()
.withTimeout(20000);
});
.withTimeout(60000);

it('should show "Running LDK" after starting up', async () => {
// await element(by.id('start')).tap();
await waitFor(element(by.text('Running LDK')))
.toBeVisible()
.withTimeout(20000);
.withTimeout(60000);

await element(by.id('E2ETest')).tap();

await waitFor(element(by.text('e2e success')))
.toBeVisible()
.withTimeout(20000);
.withTimeout(60000);
});
});
16 changes: 9 additions & 7 deletions example/ldk/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,15 @@ export const setupLdk = async (
return err(storageRes.error);
}

const res = await ldk.backupSetup({
network: ldkNetwork(selectedNetwork),
seed: account.seed,
details: backupServerDetails!,
});
if (res.isErr()) {
return err(res.error);
if (backupServerDetails) {
const res = await ldk.backupSetup({
network: ldkNetwork(selectedNetwork),
seed: account.seed,
details: backupServerDetails,
});
if (res.isErr()) {
return err(res.error);
}
}

const lmStart = await lm.start({
Expand Down
2 changes: 1 addition & 1 deletion example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"bitcoin-json-rpc": "^1.3.2",
"chai-as-promised": "^7.1.1",
"concurrently": "^8.2.0",
"detox": "20.7.0",
"detox": "20.17.0",
"electrum-client": "github:BlueWallet/rn-electrum-client#47acb51149e97fab249c3f8a314f708dbee4fb6e",
"eslint": "8.27.0",
"eslint-config-prettier": "^8.5.0",
Expand Down
29 changes: 16 additions & 13 deletions example/tests/clightning.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { describe, it } from 'mocha';
import lm, { ENetworks, ldk } from '@synonymdev/react-native-ldk';
import BitcoinJsonRpc from 'bitcoin-json-rpc';
import { describe, it } from 'mocha';
import RNFS from 'react-native-fs';
import lm, { ldk } from '@synonymdev/react-native-ldk';

import {
CL,
TestProfile,
backupServerDetails,
initWaitForElectrumToSync,
skipRemoteBackups,
sleep,
wipeLdkStorage,
} from './utils';
Expand All @@ -32,7 +34,7 @@ const clConfig = {
macaroon: global.environment.clmacaroon,
};

describe('Clightning', function () {
describe.skip('Clightning', function () {
this.retries(3);
this.timeout(5 * 60 * 1000); // 5 minutes
let waitForElectrum: any;
Expand Down Expand Up @@ -77,15 +79,7 @@ describe('Clightning', function () {
beforeEach(async () => {
await waitForElectrum({ cl: true });

// const electrumResponse = await connectToElectrum({});
// if (electrumResponse.isErr()) {
// throw electrumResponse.error;
// }
// const account = await getAccount();

profile = new TestProfile({
// name: account.name,
// seed: account.seed,
headerCallback: async (): Promise<void> => {
const syncRes = await lm.syncLdk();
if (syncRes.isErr()) {
Expand All @@ -112,8 +106,6 @@ describe('Clightning', function () {
// - open CL -> LDK channel
// - make a few payments

// const account = await getAccount();

await ldk.stop();
const lmStart = await lm.start({
...profile.getStartParams(),
Expand All @@ -132,6 +124,17 @@ describe('Clightning', function () {
throw lmStart.error;
}

if (!skipRemoteBackups) {
const backupRes = await ldk.backupSetup({
network: ENetworks.regtest,
seed: profile.getAccount().seed,
details: backupServerDetails,
});
if (backupRes.isErr()) {
throw backupRes.error;
}
}

const nodeId = await ldk.nodeId();
if (nodeId.isErr()) {
throw nodeId.error;
Expand Down
43 changes: 15 additions & 28 deletions example/tests/eclair.ts
Original file line number Diff line number Diff line change
@@ -1,30 +1,18 @@
import { describe, it } from 'mocha';
import lm, { ENetworks, ldk } from '@synonymdev/react-native-ldk';
import BitcoinJsonRpc from 'bitcoin-json-rpc';
import { describe, it } from 'mocha';
import RNFS from 'react-native-fs';
import lm, { ldk } from '@synonymdev/react-native-ldk';

import {
Eclair,
TestProfile,
backupServerDetails,
initWaitForElectrumToSync,
skipRemoteBackups,
sleep,
wipeLdkStorage,
} from './utils';

// import {
// broadcastTransaction,
// getBestBlock,
// getTransactionData,
// getTransactionPosition,
// } from '../ldk';
// import {
// connectToElectrum,
// getScriptPubKeyHistory,
// subscribeToHeader,
// } from '../electrum';r
// import { getAccount, getAddress, ldkNetwork } from '../utils/helpers';
// import { selectedNetwork } from '../utils/constants';

const bitcoinURL = 'http://polaruser:polarpass@localhost:9091';
const eclairConfig = {
host: 'localhost',
Expand Down Expand Up @@ -112,21 +100,9 @@ describe('Eclair', function () {
// - open Eclair -> LDK channel
// - make a few payments

// const account = await getAccount();

await ldk.stop();
const lmStart = await lm.start({
...profile.getStartParams(),
// getBestBlock: getBestBlock,
// account: account,
// getAddress: getAddress,
// getScriptPubKeyHistory: getScriptPubKeyHistory,
// getFees: () =>
// Promise.resolve({ highPriority: 10, normal: 5, background: 1 }),
// getTransactionData: getTransactionData,
// getTransactionPosition: getTransactionPosition,
// broadcastTransaction: broadcastTransaction,
// network: ldkNetwork(selectedNetwork),
getFees: () => {
return Promise.resolve({
onChainSweep: 30,
Expand All @@ -143,6 +119,17 @@ describe('Eclair', function () {
throw lmStart.error;
}

if (!skipRemoteBackups) {
const backupRes = await ldk.backupSetup({
network: ENetworks.regtest,
seed: profile.getAccount().seed,
details: backupServerDetails,
});
if (backupRes.isErr()) {
throw backupRes.error;
}
}

const nodeId = await ldk.nodeId();
if (nodeId.isErr()) {
throw nodeId.error;
Expand Down
Loading
Loading