feat: allow for backing up any file to remote backup server #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Jasonvdb
commented
Jan 25, 2024
Jasonvdb
commented
- Allows for backing up and retrieving other non LDK related files
- Cleans up old event based backup logic but still keeps import function to allow older backups to be restore
- Removes backup setup outside of lm.start so apps need to call this first. Makes it more flexible as it can be used without starting LDK.
- Fixes a crash that happens when app is used without remote backups
limpbrains
previously approved these changes
Jan 25, 2024
ovitrif
previously approved these changes
Jan 25, 2024
Jasonvdb
force-pushed
the
backup-cleanup
branch
from
707296e to
16dc22f
Compare
limpbrains
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.