fix: remove js payment timeout #202
Merged
+1
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes payWithTimeout function that uses a JS timeout and just relies on LDK's timeout.
This fixes an issue where JS would timeout before LDK so a payment would be a success but look like an error. JS has a hard timeout while LDK will just not retry a payment after a timeout value (so it could take a few seconds longer than the passed timeout value).
Previously there was no timeout param in LDK for paying so we had an interim solution to timeout in JS and return an error but this is no longer needed.