Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove js payment timeout #202

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: remove js payment timeout #202

merged 1 commit into from
Jan 18, 2024

Conversation

Jasonvdb
Copy link
Collaborator

Removes payWithTimeout function that uses a JS timeout and just relies on LDK's timeout.

This fixes an issue where JS would timeout before LDK so a payment would be a success but look like an error. JS has a hard timeout while LDK will just not retry a payment after a timeout value (so it could take a few seconds longer than the passed timeout value).

Previously there was no timeout param in LDK for paying so we had an interim solution to timeout in JS and return an error but this is no longer needed.

@Jasonvdb Jasonvdb merged commit 213b26a into master Jan 18, 2024
4 of 6 checks passed
@Jasonvdb Jasonvdb deleted the timeout-fix branch January 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants