Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ios and android catch channel write fails #201

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: ios and android catch channel write fails #201

merged 1 commit into from
Jan 18, 2024

Conversation

Jasonvdb
Copy link
Collaborator

  • safely catch disk write fails. LDK will retry.
  • version bump

@Jasonvdb Jasonvdb requested a review from ovitrif January 17, 2024 13:00
ovitrif
ovitrif requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a small typo that would keep logs cleaner once addressed 👍🏻

lib/ios/Classes/LdkPersist.swift Outdated Show resolved Hide resolved
@Jasonvdb Jasonvdb requested a review from ovitrif January 18, 2024 07:53
@Jasonvdb Jasonvdb merged commit 77600e9 into master Jan 18, 2024
4 of 6 checks passed
@Jasonvdb Jasonvdb deleted the disk-save-check branch January 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovitrif ovitrif ovitrif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasonvdb @ovitrif