Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: crash preventing user to ever recover wallet on Android #200

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix: crash preventing user to ever recover wallet on Android #200

merged 1 commit into from
Jan 15, 2024

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Jan 12, 2024

Fixes the bitkit issue:

For testing:

  • Use the repro steps from the bitkit issue

Note:
On iOS this is already patched with the same logic, defaulting to 0 if the cast doesn't succeed.

@ovitrif ovitrif requested a review from Jasonvdb January 12, 2024 19:16
@ovitrif ovitrif linked an issue Jan 12, 2024 that may be closed by this pull request
[Bug]: Irreparable crash when paying LN invoice to user with app closed synonymdev/bitkit#1494
Closed
@ovitrif
Copy link
Contributor Author

ovitrif commented Jan 12, 2024

Note to self: @ovitrif update the package version.

@Jasonvdb Jasonvdb merged commit 2076a20 into master Jan 15, 2024
4 of 6 checks passed
@Jasonvdb Jasonvdb deleted the fix-cast-crash branch January 15, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasonvdb Jasonvdb Jasonvdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Irreparable crash when paying LN invoice to user with app closed
2 participants
@ovitrif @Jasonvdb