Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-populated scorer download #190

Merged
merged 6 commits into from
Nov 14, 2023
Merged

feat: pre-populated scorer download #190

merged 6 commits into from
Nov 14, 2023

Conversation

Jasonvdb
Copy link
Collaborator

@Jasonvdb Jasonvdb commented Nov 9, 2023

  • Android and iOS download a pre-populated scorer from RGS server to improve payment reliability.
  • Removed old backup function calls from example app.
  • Added deprecated warnings to old backup calls, will remove completely in a future PR to simplify the code.
  • Startup speed improvements:
    • Grouped startup functions that are not required to be run in any order to run async.
    • Skip startup param check skipParamCheck: true in lm.start(). Can be left on default false for debugging but should be used to avoid additional network calls on each startup once in prod.
    • addPeers and sync methods called without await at the end of startup.

@Jasonvdb Jasonvdb changed the title Scorer download feat: pre-populated scorer download Nov 10, 2023
@Jasonvdb Jasonvdb marked this pull request as ready for review November 10, 2023 08:09
@coreyphillips
Copy link
Collaborator

coreyphillips commented Nov 13, 2023

Having stuttering and freezing issues on live Bitkit Mainnet Android device.

2023-11-13 10:27:11 DEBUG (JS): setAccountStoragePath() success. 
2023-11-13 10:27:11 DEBUG (JS): readFromFile() success. "seed"
2023-11-13 10:27:12 DEBUG (JS): initKeysManager() success. 
2023-11-13 10:27:12 DEBUG (LDK): Processing RGS update from 1699876800 with 0 nodes, 0 channel announcements and 0 channel updates. (lightning_rapid_gossip_sync::processing 148)
2023-11-13 10:27:12 DEBUG (JS): initNetworkGraph() success. "Rapid gossip sync Enabled"
2023-11-13 10:27:12 DEBUG (JS): initUserConfig() success. {"channel_handshake_config":{"announced_channel":false,"minimum_depth":1,"max_htlc_value_in_flight_percent_of_channel":100,"max_inbound_htlc_value_in_flight_percent_of_channel":100,"negotiate_anchors_zero_fee_htlc_tx":true},"manually_accept_inbound_channels":true,"accept_inbound_channels":true}
2023-11-13 10:27:12 INFO (LDK): Successfully loaded channel e1735f27c23cbe9f5ff1186cb0a218077caeabcee111234786d6779906d9fd11 at update_id 650 against monitor at update id 650 (lightning::ln::channelmanager 10002)
2023-11-13 10:27:12 INFO (LDK): Queueing monitor update to ensure missing channel 9d321251813d5a6ee7f3818fd5e453f3c7a3d134c3a42e8f1d57e8e563d8f969 is force closed (lightning::ln::channelmanager 10047)
2023-11-13 10:27:12 Node ID: 02bc2b169133131d0290fde406d4293cd2e40d777ef8875f6de9866c3f8a0ffea4
2023-11-13 10:28:39 ERROR (LDK): ChannelMonitor[Update] persistence failed unrecoverably. This indicates we cannot continue normal operation and must shut down. (lightning::chain::chainmonitor 736)

@coreyphillips
Copy link
Collaborator

Fresh installs seem fine for both bitkit (master)-react-native-ldk (master) & bitkit (master)-react-native-ldk (scorer-download). Unable to reproduce initial stutter/freeze issue.

@Jasonvdb Jasonvdb merged commit b65af23 into master Nov 14, 2023
4 of 6 checks passed
@Jasonvdb Jasonvdb deleted the scorer-download branch November 14, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants