New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lightning): Limit lm.start Calls #182

Merged

Jasonvdb merged 1 commit into master from limit-lm-start-calls

Oct 17, 2023

Collaborator

coreyphillips commented Oct 17, 2023

This PR:

Prevents simultaneous calls to lm.start.
Will allow for multiple calls if a new account name is passed to the lm.start method.
Adds isStarting, pendingStartPromises & previousAccountName to lightning-manager.ts.
Adds resolveAllPendingStartPromises & handleStartError to lightning-manager.ts.
Updates start method in lightning-manager.ts accordingly.


          fix(lightning): Limit lm.start Calls

bd610af

Prevents simultaneous calls to lm.start.

coreyphillips requested a review from Jasonvdb

October 17, 2023 13:17

Jasonvdb approved these changes

View reviewed changes

Jasonvdb merged commit 50b625d into master

5 of 6 checks passed

Jasonvdb deleted the limit-lm-start-calls branch

October 17, 2023 13:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet