Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dump useful node info to logs on startup and each sync #174

Merged
merged 2 commits into from
Oct 6, 2023
Merged

feat: dump useful node info to logs on startup and each sync #174

merged 2 commits into from
Oct 6, 2023

Conversation

Jasonvdb
Copy link
Collaborator

@Jasonvdb Jasonvdb commented Oct 5, 2023

  • Refactors claimable balance result into a reusable function getClaimableBalancesAsJson() in Swift and Kotlin
  • Dumps node state to log file on startup and each sync for debugging.
    • Node ID
    • Open channel details
    • All claimable balances
    • RGS last sync time
    • Connected peers
    • Storage
    • Backup status

@Jasonvdb Jasonvdb requested review from limpbrains and pwltr October 5, 2023 10:12
pwltr
pwltr approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@pwltr pwltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing to run the example project so not tested but LGTM.

@Jasonvdb Jasonvdb merged commit 9f0a599 into master Oct 6, 2023
@Jasonvdb Jasonvdb deleted the node-state-dump branch October 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwltr pwltr pwltr approved these changes

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jasonvdb @limpbrains @pwltr